Movatterモバイル変換

Skip to content

postgrespro/postgresproPublic

NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit16a906f

robertmhaas

committed

Make DISCARD SEQUENCES also discard the last used sequence.

Otherwise, we access already-freed memory. Oops.Report by Michael Paquier. Fix by me.

1 parent689746c commit16a906fCopy full SHA for 16a906f

File tree

3 files changed

+7

-0

lines changed

src
- backend/commands
  - sequence.c
- test/regress
  - expected
    - sequence.out
  - sql
    - sequence.sql

3 files changed

+7

-0

lines changed

`‎src/backend/commands/sequence.c`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1617,4 +1617,6 @@ ResetSequenceCaches(void)`
`1617`	`1617`	`free(seqtab);`
`1618`	`1618`	`seqtab=next;`
`1619`	`1619`	`}`
	`1620`	`+`
	`1621`	`+last_used_seq=NULL;`
`1620`	`1622`	`}`

`‎src/test/regress/expected/sequence.out`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -344,6 +344,9 @@ SELECT lastval();`
`344`	`344`	`99`
`345`	`345`	`(1 row)`
`346`	`346`
	`347`	`+DISCARD SEQUENCES;`
	`348`	`+SELECT lastval();`
	`349`	`+ERROR: lastval is not yet defined in this session`
`347`	`350`	`CREATE SEQUENCE seq2;`
`348`	`351`	`SELECT nextval('seq2');`
`349`	`352`	`nextval`

`‎src/test/regress/sql/sequence.sql`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -154,6 +154,8 @@ SELECT nextval('seq');`
`154`	`154`	`SELECT lastval();`
`155`	`155`	`SELECT setval('seq',99);`
`156`	`156`	`SELECT lastval();`
	`157`	`+DISCARD SEQUENCES;`
	`158`	`+SELECT lastval();`
`157`	`159`
`158`	`160`	`CREATESEQUENCEseq2;`
`159`	`161`	`SELECT nextval('seq2');`

0 commit comments

Comments

(0)

[8]ページ先頭

©2009-2025 Movatter.jp