NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit15b5d6c

committed

I noticed in the 7.4 release that in contrib/pg_autovacuum, args->logfile is

not initialized if a log file is not specified on the command line. Thiscauses an immediate segfault on systems that fill allocated memory with somevalue other than zero (my FreeBSD machine uses 0xD0).Several crashes later I discovered that args->user, password, host, and portare also used without being initialized.This doesn't appear to be fixed in CVS and I came up empty on a mailing listsearch -- hope it hasn't been reported already.Craig Boston

1 parent5ef01a2 commit15b5d6cCopy full SHA for 15b5d6c

File tree

1 file changed

-0

lines changed

contrib/pg_autovacuum
- pg_autovacuum.c

1 file changed

-0

lines changed

`‎contrib/pg_autovacuum/pg_autovacuum.c`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -811,6 +811,11 @@ get_cmd_args(int argc, char *argv[])`
`811`	`811`	`args->analyze_scaling_factor=-1;`
`812`	`812`	`args->debug=AUTOVACUUM_DEBUG;`
`813`	`813`	`args->daemonize=0;`
	`814`	`+args->user=0;`
	`815`	`+args->password=0;`
	`816`	`+args->host=0;`
	`817`	`+args->logfile=0;`
	`818`	`+args->port=0;`
`814`	`819`
`815`	`820`	`/*`
`816`	`821`	`* Fixme: Should add some sanity checking such as positive integer`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit15b5d6c

File tree

1 file changed

1 file changed

`‎contrib/pg_autovacuum/pg_autovacuum.c`

0 commit comments