- Notifications
You must be signed in to change notification settings - Fork5
Commit15b1918
committed
Improve reporting of permission errors for array types
Because permissions are assigned to element types, not array types,complaining about permission denied on an array type would bemisleading to users. So adjust the reporting to refer to the elementtype instead.In order not to duplicate the required logic in two dozen places,refactor the permission denied reporting for types a bit.pointed out by Yeb Havinga during the review of the type privilegefeature1 parentd933092 commit15b1918
File tree
11 files changed
+39
-47
lines changed- src
- backend
- access/common
- catalog
- commands
- include/utils
- test/regress/expected
11 files changed
+39
-47
lines changedLines changed: 1 addition & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
573 | 573 |
| |
574 | 574 |
| |
575 | 575 |
| |
576 |
| - | |
577 |
| - | |
| 576 | + | |
578 | 577 |
| |
579 | 578 |
| |
580 | 579 |
| |
|
Lines changed: 13 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
3389 | 3389 |
| |
3390 | 3390 |
| |
3391 | 3391 |
| |
| 3392 | + | |
| 3393 | + | |
| 3394 | + | |
| 3395 | + | |
| 3396 | + | |
| 3397 | + | |
| 3398 | + | |
| 3399 | + | |
| 3400 | + | |
| 3401 | + | |
| 3402 | + | |
| 3403 | + | |
| 3404 | + | |
3392 | 3405 |
| |
3393 | 3406 |
| |
3394 | 3407 |
| |
|
Lines changed: 1 addition & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
937 | 937 |
| |
938 | 938 |
| |
939 | 939 |
| |
940 |
| - | |
941 |
| - | |
| 940 | + | |
942 | 941 |
| |
943 | 942 |
| |
944 | 943 |
| |
|
Lines changed: 3 additions & 6 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
208 | 208 |
| |
209 | 209 |
| |
210 | 210 |
| |
211 |
| - | |
212 |
| - | |
| 211 | + | |
213 | 212 |
| |
214 | 213 |
| |
215 | 214 |
| |
216 | 215 |
| |
217 |
| - | |
218 |
| - | |
| 216 | + | |
219 | 217 |
| |
220 | 218 |
| |
221 | 219 |
| |
222 |
| - | |
223 |
| - | |
| 220 | + | |
224 | 221 |
| |
225 | 222 |
| |
226 | 223 |
| |
|
Lines changed: 4 additions & 8 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
154 | 154 |
| |
155 | 155 |
| |
156 | 156 |
| |
157 |
| - | |
158 |
| - | |
| 157 | + | |
159 | 158 |
| |
160 | 159 |
| |
161 | 160 |
| |
| |||
247 | 246 |
| |
248 | 247 |
| |
249 | 248 |
| |
250 |
| - | |
251 |
| - | |
| 249 | + | |
252 | 250 |
| |
253 | 251 |
| |
254 | 252 |
| |
| |||
1510 | 1508 |
| |
1511 | 1509 |
| |
1512 | 1510 |
| |
1513 |
| - | |
1514 |
| - | |
| 1511 | + | |
1515 | 1512 |
| |
1516 | 1513 |
| |
1517 | 1514 |
| |
1518 |
| - | |
1519 |
| - | |
| 1515 | + | |
1520 | 1516 |
| |
1521 | 1517 |
| |
1522 | 1518 |
| |
|
Lines changed: 2 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
414 | 414 |
| |
415 | 415 |
| |
416 | 416 |
| |
417 |
| - | |
418 |
| - | |
| 417 | + | |
419 | 418 |
| |
420 | 419 |
| |
421 | 420 |
| |
| |||
565 | 564 |
| |
566 | 565 |
| |
567 | 566 |
| |
568 |
| - | |
569 |
| - | |
| 567 | + | |
570 | 568 |
| |
571 | 569 |
| |
572 | 570 |
| |
|
Lines changed: 3 additions & 6 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
181 | 181 |
| |
182 | 182 |
| |
183 | 183 |
| |
184 |
| - | |
185 |
| - | |
| 184 | + | |
186 | 185 |
| |
187 | 186 |
| |
188 | 187 |
| |
189 | 188 |
| |
190 | 189 |
| |
191 | 190 |
| |
192 |
| - | |
193 |
| - | |
| 191 | + | |
194 | 192 |
| |
195 | 193 |
| |
196 | 194 |
| |
| |||
227 | 225 |
| |
228 | 226 |
| |
229 | 227 |
| |
230 |
| - | |
231 |
| - | |
| 228 | + | |
232 | 229 |
| |
233 | 230 |
| |
234 | 231 |
| |
|
Lines changed: 3 additions & 6 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
526 | 526 |
| |
527 | 527 |
| |
528 | 528 |
| |
529 |
| - | |
530 |
| - | |
| 529 | + | |
531 | 530 |
| |
532 | 531 |
| |
533 | 532 |
| |
| |||
4500 | 4499 |
| |
4501 | 4500 |
| |
4502 | 4501 |
| |
4503 |
| - | |
4504 |
| - | |
| 4502 | + | |
4505 | 4503 |
| |
4506 | 4504 |
| |
4507 | 4505 |
| |
| |||
7248 | 7246 |
| |
7249 | 7247 |
| |
7250 | 7248 |
| |
7251 |
| - | |
7252 |
| - | |
| 7249 | + | |
7253 | 7250 |
| |
7254 | 7251 |
| |
7255 | 7252 |
| |
|
Lines changed: 6 additions & 12 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
758 | 758 |
| |
759 | 759 |
| |
760 | 760 |
| |
761 |
| - | |
762 |
| - | |
| 761 | + | |
763 | 762 |
| |
764 | 763 |
| |
765 | 764 |
| |
| |||
1208 | 1207 |
| |
1209 | 1208 |
| |
1210 | 1209 |
| |
1211 |
| - | |
1212 |
| - | |
| 1210 | + | |
1213 | 1211 |
| |
1214 | 1212 |
| |
1215 | 1213 |
| |
| |||
2809 | 2807 |
| |
2810 | 2808 |
| |
2811 | 2809 |
| |
2812 |
| - | |
2813 |
| - | |
| 2810 | + | |
2814 | 2811 |
| |
2815 | 2812 |
| |
2816 | 2813 |
| |
| |||
3116 | 3113 |
| |
3117 | 3114 |
| |
3118 | 3115 |
| |
3119 |
| - | |
3120 |
| - | |
| 3116 | + | |
3121 | 3117 |
| |
3122 | 3118 |
| |
3123 | 3119 |
| |
| |||
3238 | 3234 |
| |
3239 | 3235 |
| |
3240 | 3236 |
| |
3241 |
| - | |
3242 |
| - | |
| 3237 | + | |
3243 | 3238 |
| |
3244 | 3239 |
| |
3245 | 3240 |
| |
| |||
3367 | 3362 |
| |
3368 | 3363 |
| |
3369 | 3364 |
| |
3370 |
| - | |
3371 |
| - | |
| 3365 | + | |
3372 | 3366 |
| |
3373 | 3367 |
| |
3374 | 3368 |
| |
|
Lines changed: 2 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
302 | 302 |
| |
303 | 303 |
| |
304 | 304 |
| |
| 305 | + | |
| 306 | + | |
305 | 307 |
| |
306 | 308 |
| |
307 | 309 |
| |
|
Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
547 | 547 |
| |
548 | 548 |
| |
549 | 549 |
| |
550 |
| - | |
| 550 | + | |
551 | 551 |
| |
552 | 552 |
| |
553 | 553 |
| |
|
0 commit comments
Comments
(0)