NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commit14ee357

committed

Fix portability bug in gin_page_opaque_info().

Somebody apparently thought that "if Int32GetDatum is good,Int64GetDatum must be better". Per buildfarm failures nowthat Peter has added some regression tests here.

1 parentf7c9a6e commit14ee357Copy full SHA for 14ee357

File tree

1 file changed

-4

lines changed

contrib/pageinspect
- ginfuncs.c

1 file changed

-4

lines changed

`‎contrib/pageinspect/ginfuncs.c‎`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ gin_page_opaque_info(PG_FUNCTION_ARGS)`
`100`	`100`	`GinPageOpaqueopaq;`
`101`	`101`	`HeapTupleresultTuple;`
`102`	`102`	`Datumvalues[3];`
`103`		`-boolnulls[10];`
	`103`	`+boolnulls[3];`
`104`	`104`	`Datumflags[16];`
`105`	`105`	`intnflags=0;`
`106`	`106`	`uint16flagbits;`
`@@ -152,9 +152,9 @@ gin_page_opaque_info(PG_FUNCTION_ARGS)`
`152`	`152`	`memset(nulls,0,sizeof(nulls));`
`153`	`153`
`154`	`154`	`values[0]=Int64GetDatum(opaq->rightlink);`
`155`		`-values[1]=Int64GetDatum(opaq->maxoff);`
`156`		`-values[2]=PointerGetDatum(`
`157`		`-construct_array(flags,nflags,TEXTOID,-1, false,'i'));`
	`155`	`+values[1]=Int32GetDatum(opaq->maxoff);`
	`156`	`+values[2]=PointerGetDatum(construct_array(flags,nflags,`
	`157`	`+TEXTOID,-1, false,'i'));`
`158`	`158`
`159`	`159`	`/* Build and return the result tuple. */`
`160`	`160`	`resultTuple=heap_form_tuple(tupdesc,values,nulls);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit14ee357

File tree

1 file changed

1 file changed

`‎contrib/pageinspect/ginfuncs.c‎`

0 commit comments