Commit149e38e

committed

Assorted bgworker-related comment fixes.

Per gripes by Amit Kapila.

1 parent813fb03 commit149e38eCopy full SHA for 149e38e

File tree

+12

-12

lines changed

+12

-12

lines changed

Lines changed: 5 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -134,17 +134,15 @@ BackgroundWorkerShmemInit(void)`
`134`	`134`	`Assert(found);`
`135`	`135`	`}`
`136`	`136`
	`137`	`+/*`
	`138`	`+ * Search the postmaster's backend-private list of RegisteredBgWorker objects`
	`139`	`+ * for the one that maps to the given slot number.`
	`140`	`+ */`
`137`	`141`	`staticRegisteredBgWorker*`
`138`	`142`	`FindRegisteredWorkerBySlotNumber(intslotno)`
`139`	`143`	`{`
`140`	`144`	`slist_itersiter;`
`141`	`145`
`142`		`-/*`
`143`		`- * Copy contents of worker list into shared memory. Record the`
`144`		`- * shared memory slot assigned to each worker. This ensures`
`145`		`- * a 1-to-1 correspondence betwen the postmaster's private list and`
`146`		`- * the array in shared memory.`
`147`		`- */`
`148`	`146`	`slist_foreach(siter,&BackgroundWorkerList)`
`149`	`147`	`{`
`150`	`148`	`RegisteredBgWorker*rw;`
`@@ -158,7 +156,7 @@ FindRegisteredWorkerBySlotNumber(int slotno)`
`158`	`156`	`}`
`159`	`157`
`160`	`158`	`/*`
`161`		`- * Notice changes toshared_memory made by other backends. This code`
	`159`	`+ * Notice changes toshared memory made by other backends. This code`
`162`	`160`	`* runs in the postmaster, so we must be very careful not to assume that`
`163`	`161`	`* shared memory contents are sane. Otherwise, a rogue backend could take`
`164`	`162`	`* out the postmaster.`

Lines changed: 7 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,11 +6,13 @@`
`6`	`6`	`* including normal transactions.`
`7`	`7`	`*`
`8`	`8`	`* Any external module loaded via shared_preload_libraries can register a`
`9`		`- * worker.Then, at the appropriate time, the worker process is forked from`
`10`		`- * the postmaster and runs the user-supplied "main" function. This code may`
`11`		`- * connect to a database and run transactions.Once started, it stays active`
`12`		`- * until shutdown or crash. The process should sleep during periods of`
`13`		`- * inactivity.`
	`9`	`+ * worker.Workers can also be registered dynamically at runtime. In either`
	`10`	`+ * case, the worker process is forked from the postmaster and runs the`
	`11`	`+ * user-supplied "main" function. This code may connect to a database and`
	`12`	`+ * run transactions. Once started, it stays active until shutdown or crash;`
	`13`	`+ * unless the restart interval is declared as BGW_NEVER_RESTART and the`
	`14`	`+ * process exits with a return code of 1; workers that do this are`
	`15`	`+ * automatically unregistered by the postmaster.`
`14`	`16`	`*`
`15`	`17`	`* If the fork() call fails in the postmaster, it will try again later. Note`
`16`	`18`	`* that the failure can only be transient (fork failure due to high load,`

Comments

(0)