NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit1460b19

committed

Assert that pre/post-fix updated tuples are on the same page during replay.

If they were not 'oldtup.t_data' would be dereferenced while set to NULLin case of a full page image for block 0.Do so primarily to silence coverity; but also to make sure this prerequisiteisn't changed without adapting the replay routine as that would appear towork in many cases.Andres Freund

1 parenta692ee5 commit1460b19Copy full SHA for 1460b19

File tree

1 file changed

-0

lines changed

src/backend/access/heap
- heapam.c

1 file changed

-0

lines changed

`‎src/backend/access/heap/heapam.c`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -8115,11 +8115,13 @@ newsame:;`
`8115`	`8115`
`8116`	`8116`	`if (xlrec->flags&XLOG_HEAP_PREFIX_FROM_OLD)`
`8117`	`8117`	`{`
	`8118`	`+Assert(samepage);`
`8118`	`8119`	`memcpy(&prefixlen,recdata,sizeof(uint16));`
`8119`	`8120`	`recdata+=sizeof(uint16);`
`8120`	`8121`	`}`
`8121`	`8122`	`if (xlrec->flags&XLOG_HEAP_SUFFIX_FROM_OLD)`
`8122`	`8123`	`{`
	`8124`	`+Assert(samepage);`
`8123`	`8125`	`memcpy(&suffixlen,recdata,sizeof(uint16));`
`8124`	`8126`	`recdata+=sizeof(uint16);`
`8125`	`8127`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1460b19

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/heapam.c`

0 commit comments