Commit13a6fa3

committed

pg_upgrade: Add C comment about NextXID delimiter

We don't test the catversion for the NextXID delimiter change, we justtest the string contents; explain why.Reported-by: Michael Paquier

1 parent59a884e commit13a6fa3Copy full SHA for 13a6fa3

File tree

-1

lines changed

-1

lines changed

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -197,9 +197,14 @@ get_control_data(ClusterInfo *cluster, bool live_check)`
`197`	`197`	`p++;/* remove ':' char */`
`198`	`198`	`cluster->controldata.chkpnt_nxtepoch=str2uint(p);`
`199`	`199`
	`200`	`+/*`
	`201`	`+ * Delimiter changed from '/' to ':' in 9.6. We don't test for`
	`202`	`+ * the catalog version of the change because the catalog version`
	`203`	`+ * is pulled from pg_controldata too, and it isn't worth adding`
	`204`	`+ * an order dependency for this --- we just check the string.`
	`205`	`+ */`
`200`	`206`	`if (strchr(p,'/')!=NULL)`
`201`	`207`	`p=strchr(p,'/');`
`202`		`-/* delimiter changed from '/' to ':' in 9.6 */`
`203`	`208`	`elseif (GET_MAJOR_VERSION(cluster->major_version) >=906)`
`204`	`209`	`p=strchr(p,':');`
`205`	`210`	`else`

Comments

(0)