Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit12d1143

Browse files
committed
Fix possible null pointer dereference or invalid warning message.
Thinko in commitde43897: this warning message references the wrong"LogicalRepWorker *" variable. This would often result in a core dump,but if it didn't, the message would show the wrong subscription OID.In passing, adjust the message text to format a subscription OIDsimilarly to how that's done elsewhere in the function; and fixgrammatical issues in some nearby messages.Per Coverity testing.
1 parentc238442 commit12d1143

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

‎src/backend/replication/logical/launcher.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -315,8 +315,8 @@ logicalrep_worker_launch(Oid dbid, Oid subid, const char *subname, Oid userid,
315315
wal_receiver_timeout))
316316
{
317317
elog(WARNING,
318-
"logical replication worker for subscription\"%d\" took too long to start; canceled",
319-
worker->subid);
318+
"logical replication worker for subscription%u took too long to start; canceled",
319+
w->subid);
320320

321321
logicalrep_worker_cleanup(w);
322322
did_cleanup= true;
@@ -347,7 +347,7 @@ logicalrep_worker_launch(Oid dbid, Oid subid, const char *subname, Oid userid,
347347
LWLockRelease(LogicalRepWorkerLock);
348348
ereport(WARNING,
349349
(errcode(ERRCODE_CONFIGURATION_LIMIT_EXCEEDED),
350-
errmsg("out of logical replicationworkers slots"),
350+
errmsg("out of logical replicationworker slots"),
351351
errhint("You might need to increase max_logical_replication_workers.")));
352352
return;
353353
}
@@ -393,7 +393,7 @@ logicalrep_worker_launch(Oid dbid, Oid subid, const char *subname, Oid userid,
393393
{
394394
ereport(WARNING,
395395
(errcode(ERRCODE_CONFIGURATION_LIMIT_EXCEEDED),
396-
errmsg("out of backgroundworkers slots"),
396+
errmsg("out of backgroundworker slots"),
397397
errhint("You might need to increase max_worker_processes.")));
398398
return;
399399
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp