NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit121aca3

Neil Conway

committed

Minor code cleanup: hdefault() only ever returned "true", so it may as

well be declared to return "void" to save callers the trouble ofchecking for errors.

1 parenta57df8d commit121aca3Copy full SHA for 121aca3

File tree

1 file changed

-9

lines changed

src/backend/utils/hash
- dynahash.c

1 file changed

-9

lines changed

`‎src/backend/utils/hash/dynahash.c`

Lines changed: 4 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`*`
`10`	`10`	`*`
`11`	`11`	`* IDENTIFICATION`
`12`		`- * $PostgreSQL: pgsql/src/backend/utils/hash/dynahash.c,v 1.54 2004/09/28 20:46:34 tgl Exp $`
	`12`	`+ * $PostgreSQL: pgsql/src/backend/utils/hash/dynahash.c,v 1.55 2004/10/22 07:21:06 neilc Exp $`
`13`	`13`	`*`
`14`	`14`	`*-------------------------------------------------------------------------`
`15`	`15`	`*/`
`@@ -66,7 +66,7 @@ static HASHSEGMENT seg_alloc(HTAB *hashp);`
`66`	`66`	`staticboolelement_alloc(HTAB*hashp,intnelem);`
`67`	`67`	`staticbooldir_realloc(HTAB*hashp);`
`68`	`68`	`staticboolexpand_table(HTAB*hashp);`
`69`		`-staticboolhdefault(HTAB*hashp);`
	`69`	`+staticvoidhdefault(HTAB*hashp);`
`70`	`70`	`staticboolinit_htab(HTAB*hashp,longnelem);`
`71`	`71`	`staticvoidhash_corrupted(HTAB*hashp);`
`72`	`72`
`@@ -178,8 +178,7 @@ hash_create(const char tabname, long nelem, HASHCTL info, int flags)`
`178`	`178`	`returnNULL;`
`179`	`179`	`}`
`180`	`180`
`181`		`-if (!hdefault(hashp))`
`182`		`-returnNULL;`
	`181`	`+hdefault(hashp);`
`183`	`182`
`184`	`183`	`hctl=hashp->hctl;`
`185`	`184`	`#ifdefHASH_STATISTICS`
`@@ -254,7 +253,7 @@ hash_create(const char tabname, long nelem, HASHCTL info, int flags)`
`254`	`253`	`/*`
`255`	`254`	`* Set default HASHHDR parameters.`
`256`	`255`	`*/`
`257`		`-staticbool`
	`256`	`+staticvoid`
`258`	`257`	`hdefault(HTAB*hashp)`
`259`	`258`	`{`
`260`	`259`	`HASHHDR*hctl=hashp->hctl;`
`@@ -268,8 +267,6 @@ hdefault(HTAB *hashp)`
`268`	`267`	`hctl->nentries=0;`
`269`	`268`	`hctl->nsegs=0;`
`270`	`269`
`271`		`-/* I added these MS. */`
`272`		`-`
`273`	`270`	`/* rather pointless defaults for key & entry size */`
`274`	`271`	`hctl->keysize=sizeof(char*);`
`275`	`272`	`hctl->entrysize=2sizeof(char);`
`@@ -279,8 +276,6 @@ hdefault(HTAB *hashp)`
`279`	`276`
`280`	`277`	`/* garbage collection for HASH_REMOVE */`
`281`	`278`	`hctl->freeList=NULL;`
`282`		`-`
`283`		`-return true;`
`284`	`279`	`}`
`285`	`280`
`286`	`281`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit121aca3

File tree

1 file changed

1 file changed

`‎src/backend/utils/hash/dynahash.c`

0 commit comments