Commit1129c2b

committed

Correct comment in GetConflictingVirtualXIDs()

We use Share lock because it is safe to do so.

1 parent0034757 commit1129c2bCopy full SHA for 1129c2b

File tree

-2

lines changed

-2

lines changed

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2540,8 +2540,11 @@ GetConflictingVirtualXIDs(TransactionId limitXmin, Oid dbOid)`
`2540`	`2540`
`2541`	`2541`	`/*`
`2542`	`2542`	`* We ignore an invalid pxmin because this means that backend has`
`2543`		`- * no snapshot and cannot get another one while we hold exclusive`
`2544`		`- * lock.`
	`2543`	`+ * no snapshot currently. We hold a Share lock to avoid contention`
	`2544`	`+ * with users taking snapshots. That is not a problem because`
	`2545`	`+ * the current xmin is always at least one higher than the latest`
	`2546`	`+ * removed xid, so any new snapshot would never conflict with the`
	`2547`	`+ * test here.`
`2545`	`2548`	`*/`
`2546`	`2549`	`if (!TransactionIdIsValid(limitXmin)\|\|`
`2547`	`2550`	`(TransactionIdIsValid(pxmin)&& !TransactionIdFollows(pxmin,limitXmin)))`

Comments

(0)