NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit11003eb

committed

libpq: Fix inadvertent change in PQhost() behavior.

Commit274bb2b caused PQhost() toreturn the value of the hostaddr parameter rather than the relevanthost when the latter parameter was specified. That's wrong. Commit9a1d0af then amplified the damage byusing PQhost() in more places, so that the SSL test suite startedfailing.Report by Andreas Karlsson; patch by me.

1 parenta01a501 commit11003ebCopy full SHA for 11003eb

File tree

1 file changed

-1

lines changed

src/interfaces/libpq
- fe-connect.c

1 file changed

-1

lines changed

`‎src/interfaces/libpq/fe-connect.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5736,7 +5736,8 @@ PQhost(const PGconn *conn)`
`5736`	`5736`	`{`
`5737`	`5737`	`if (!conn)`
`5738`	`5738`	`returnNULL;`
`5739`		`-if (conn->connhost!=NULL)`
	`5739`	`+if (conn->connhost!=NULL&&`
	`5740`	`+conn->connhost[conn->whichhost].type!=CHT_HOST_ADDRESS)`
`5740`	`5741`	`returnconn->connhost[conn->whichhost].host;`
`5741`	`5742`	`elseif (conn->pghost!=NULL&&conn->pghost[0]!='\0')`
`5742`	`5743`	`returnconn->pghost;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit11003eb

File tree

1 file changed

1 file changed

`‎src/interfaces/libpq/fe-connect.c`

0 commit comments