@@ -611,11 +611,11 @@ check_for_isn_and_int8_passing_mismatch(ClusterInfo *cluster)
611
611
/*
612
612
* check_for_reg_data_type_usage()
613
613
*pg_upgrade only preserves these system values:
614
- *pg_class.relfilenode
614
+ *pg_class.oid
615
615
*pg_type.oid
616
616
*pg_enum.oid
617
617
*
618
- *Most of the reg* data types reference system catalog info that is
618
+ *Many of the reg* data types reference system catalog info that is
619
619
*not preserved, and hence these data types cannot be used in user
620
620
*tables upgraded by pg_upgrade.
621
621
*/
@@ -653,16 +653,16 @@ check_for_reg_data_type_usage(ClusterInfo *cluster)
653
653
"NOT a.attisdropped AND "
654
654
"a.atttypid IN ( "
655
655
"'pg_catalog.regproc'::pg_catalog.regtype, "
656
- "'pg_catalog.regprocedure'::pg_catalog.regtype, "
656
+ "'pg_catalog.regprocedure'::pg_catalog.regtype, "
657
657
"'pg_catalog.regoper'::pg_catalog.regtype, "
658
- "'pg_catalog.regoperator'::pg_catalog.regtype, "
659
- "'pg_catalog. regclass'::pg_catalog.regtype, "
658
+ "'pg_catalog.regoperator'::pg_catalog.regtype, "
659
+ /* regclass.oid is preserved, so 'regclass' is OK */
660
660
/* regtype.oid is preserved, so 'regtype' is OK */
661
- "'pg_catalog.regconfig'::pg_catalog.regtype, "
662
- "'pg_catalog.regdictionary'::pg_catalog.regtype) AND "
663
- "c.relnamespace = n.oid AND "
664
- "n.nspname != 'pg_catalog' AND "
665
- "n.nspname != 'information_schema'" );
661
+ "'pg_catalog.regconfig'::pg_catalog.regtype, "
662
+ "'pg_catalog.regdictionary'::pg_catalog.regtype) AND "
663
+ "c.relnamespace = n.oid AND "
664
+ "n.nspname != 'pg_catalog' AND "
665
+ "n.nspname != 'information_schema'" );
666
666
667
667
ntups = PQntuples (res );
668
668
i_nspname = PQfnumber (res ,"nspname" );