Commit0dac5b5

committed

Tweak targetlist-SRF tests some more.

Seems like it would be good to have a test case documenting theexisting behavior for non-top-level SRFs.

1 parent6415ba5 commit0dac5b5Copy full SHA for 0dac5b5

File tree

+17

-0

lines changed

+17

-0

lines changed

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -375,6 +375,17 @@ LINE 1: INSERT INTO fewmore VALUES(1) RETURNING generate_series(1,3)...`
`375`	`375`	`-- nor standalone VALUES (but surely this is a bug?)`
`376`	`376`	`VALUES(1, generate_series(1,2));`
`377`	`377`	`ERROR: set-valued function called in context that cannot accept a set`
	`378`	`+-- We allow tSRFs that are not at top level`
	`379`	`+SELECT int4mul(generate_series(1,2), 10);`
	`380`	`+ int4mul`
	`381`	`+---------`
	`382`	`+ 10`
	`383`	`+ 20`
	`384`	`+(2 rows)`
	`385`	`+`
	`386`	`+-- but SRFs in function RTEs must be at top level (annoying restriction)`
	`387`	`+SELECT * FROM int4mul(generate_series(1,2), 10);`
	`388`	`+ERROR: set-valued function called in context that cannot accept a set`
`378`	`389`	`-- DISTINCT ON is evaluated before tSRF evaluation if SRF is not`
`379`	`390`	`-- referenced either in ORDER BY or in the DISTINCT ON list. The ORDER`
`380`	`391`	`-- BY reference can be implicitly generated, if there's no other ORDER BY.`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,12 @@ INSERT INTO fewmore VALUES(1) RETURNING generate_series(1,3);`
`80`	`80`	`-- nor standalone VALUES (but surely this is a bug?)`
`81`	`81`	`VALUES(1, generate_series(1,2));`
`82`	`82`
	`83`	`+-- We allow tSRFs that are not at top level`
	`84`	`+SELECT int4mul(generate_series(1,2),10);`
	`85`	`+`
	`86`	`+-- but SRFs in function RTEs must be at top level (annoying restriction)`
	`87`	`+SELECT*FROM int4mul(generate_series(1,2),10);`
	`88`	`+`
`83`	`89`	`-- DISTINCT ON is evaluated before tSRF evaluation if SRF is not`
`84`	`90`	`-- referenced either in ORDER BY or in the DISTINCT ON list. The ORDER`
`85`	`91`	`-- BY reference can be implicitly generated, if there's no other ORDER BY.`

Comments

(0)