NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit0c5af0a

committed

Move BufferGetBlockNumber() out of heap_page_is_all_visible()'s inner loop.

In some workloads BufferGetBlockNumber() shows up in profiles due tothe sheer number of calls to it (and because it causes cachemisses). The compiler can't move it out of the loop because it's afull extern function call...

1 parent6c878ed commit0c5af0aCopy full SHA for 0c5af0a

File tree

1 file changed

-1

lines changed

src/backend/commands
- vacuumlazy.c

1 file changed

-1

lines changed

`‎src/backend/commands/vacuumlazy.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1754,6 +1754,7 @@ static bool`
`1754`	`1754`	`heap_page_is_all_visible(Relationrel,Bufferbuf,TransactionId*visibility_cutoff_xid)`
`1755`	`1755`	`{`
`1756`	`1756`	`Pagepage=BufferGetPage(buf);`
	`1757`	`+BlockNumberblockno=BufferGetBlockNumber(buf);`
`1757`	`1758`	`OffsetNumberoffnum,`
`1758`	`1759`	`maxoff;`
`1759`	`1760`	`boolall_visible= true;`
`@@ -1778,7 +1779,7 @@ heap_page_is_all_visible(Relation rel, Buffer buf, TransactionId *visibility_cut`
`1778`	`1779`	`if (!ItemIdIsUsed(itemid)\|\|ItemIdIsRedirected(itemid))`
`1779`	`1780`	`continue;`
`1780`	`1781`
`1781`		`-ItemPointerSet(&(tuple.t_self),BufferGetBlockNumber(buf),offnum);`
	`1782`	`+ItemPointerSet(&(tuple.t_self),blockno,offnum);`
`1782`	`1783`
`1783`	`1784`	`/*`
`1784`	`1785`	`* Dead line pointers can have index pointers pointing to them. So`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0c5af0a

File tree

1 file changed

1 file changed

`‎src/backend/commands/vacuumlazy.c`

0 commit comments