NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit0bfc64b

committed

Looks okay in a quick glance, except error message spelling is poor:

! #define ARRISNULL(x) ( (x) ? ( ( ARR_NDIM(x) == NDIM ) ? ( ( ARRNELEMS( x ) )? 0 : 1 ) : ( ( ARR_NDIM(x) ) ? (elog(ERROR,"Array is not one-dimentional: %d dimentions", ARR_NDIM(x)),1) : 1 ) ) : 1 )Should be "one-dimensional" and "dimensions". Bruce, would you fix thatwhen you apply it?Tom

1 parentf368c94 commit0bfc64bCopy full SHA for 0bfc64b

File tree

1 file changed

-1

lines changed

contrib/intarray
- _int.c

1 file changed

-1

lines changed

`‎contrib/intarray/_int.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@`
`36`	`36`	`#defineARRPTR(x) ( (int4 *) ARR_DATA_PTR(x) )`
`37`	`37`	`#defineARRNELEMS(x) ArrayGetNItems( ARR_NDIM(x), ARR_DIMS(x))`
`38`	`38`
`39`		`-#defineARRISNULL(x) ( (x) ? ( ( ARR_NDIM(x) == NDIM ) ? ( ( ARRNELEMS( x ) ) ? 0 : 1 ) : ( ( ARR_NDIM(x) ) ? (elog(ERROR,"Array is not one-dimentional: %ddimentions", ARR_NDIM(x)),1) : 1 ) ) : 1 )`
	`39`	`+#defineARRISNULL(x) ( (x) ? ( ( ARR_NDIM(x) == NDIM ) ? ( ( ARRNELEMS( x ) ) ? 0 : 1 ) : ( ( ARR_NDIM(x) ) ? (elog(ERROR,"Array is not one-dimensional: %ddimensions", ARR_NDIM(x)),1) : 1 ) ) : 1 )`
`40`	`40`	`#defineARRISVOID(x) ( (x) ? ( ( ARR_NDIM(x) == NDIM ) ? ( ( ARRNELEMS( x ) ) ? 0 : 1 ) : 1 ) : 0 )`
`41`	`41`
`42`	`42`	`#defineSORT(x) \`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0bfc64b

File tree

1 file changed

1 file changed

`‎contrib/intarray/_int.c`

0 commit comments