NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit09c6ac9

committed

Dept. of second thoughts: it'd be a good idea to flush buffers

during replay of CREATE DATABASE as well as the first time around.Else it's possible that the copy operation will copy obsolete blocks.We are still a long way from guaranteeing anything about using arecently-written database as a CREATE template, but this seems neededto ensure the existing behavior holds up during replay.

1 parent3afd7ea commit09c6ac9Copy full SHA for 09c6ac9

File tree

1 file changed

-1

lines changed

src/backend/commands
- dbcommands.c

1 file changed

-1

lines changed

`‎src/backend/commands/dbcommands.c`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`*`
`10`	`10`	`*`
`11`	`11`	`* IDENTIFICATION`
`12`		`- * $PostgreSQL: pgsql/src/backend/commands/dbcommands.c,v 1.143 2004/08/3002:54:38 momjian Exp $`
	`12`	`+ * $PostgreSQL: pgsql/src/backend/commands/dbcommands.c,v 1.144 2004/08/3003:50:24 tgl Exp $`
`13`	`13`	`*`
`14`	`14`	`*-------------------------------------------------------------------------`
`15`	`15`	`*/`
`@@ -1136,6 +1136,13 @@ dbase_redo(XLogRecPtr lsn, XLogRecord *record)`
`1136`	`1136`	`dst_path)));`
`1137`	`1137`	`}`
`1138`	`1138`
	`1139`	`+/*`
	`1140`	`+ * Force dirty buffers out to disk, to ensure source database is`
	`1141`	`+ * up-to-date for the copy. (We really only need to flush buffers for`
	`1142`	`+ * the source database...)`
	`1143`	`+ */`
	`1144`	`+BufferSync(-1,-1);`
	`1145`	`+`
`1139`	`1146`	`#ifndefWIN32`
`1140`	`1147`
`1141`	`1148`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit09c6ac9

File tree

1 file changed

1 file changed

`‎src/backend/commands/dbcommands.c`

0 commit comments