- Notifications
You must be signed in to change notification settings - Fork5
Commit07a4a93
committed
Initialize tsId and dbId fields in WAL record of COMMIT PREPARED.
Commitdd428c7 added dbId and tsId to the xl_xact_commit struct but missedthat prepared transaction commits reuse that struct. Fix that.Because those fields were left unitialized, replaying a commit prepared WALrecord in a hot standby node would fail to remove the relcache init file.That can lead to "could not open file" errors on the standby. Relcache initfile only needs to be removed when a system table/index is rewritten in thetransaction using two phase commit, so that should be rare in practice. InHEAD, the incorrect dbId/tsId values are also used for filtering in logicalreplication code, causing the transaction to always be filtered out.Analysis and fix by Andres Freund. Backpatch to 9.0 where hot standby wasintroduced.1 parentf62d417 commit07a4a93
1 file changed
+6
-2
lines changedLines changed: 6 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2082 | 2082 |
| |
2083 | 2083 |
| |
2084 | 2084 |
| |
2085 |
| - | |
| 2085 | + | |
2086 | 2086 |
| |
2087 |
| - | |
| 2087 | + | |
| 2088 | + | |
| 2089 | + | |
| 2090 | + | |
| 2091 | + | |
2088 | 2092 |
| |
2089 | 2093 |
| |
2090 | 2094 |
| |
|
0 commit comments
Comments
(0)