NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit067e40c

committed

Do a CHECK_FOR_INTERRUPTS immediately before terminating a fastpath

function call. Previously, there may have been no CHECK_FOR_INTERRUPTSat all in the fastpath code path, making it impossible to cancel anoperation such as \lo_import externally. This addition doesn't ensureyou can cancel, since your SIGINT may arrive while the backend is idlewaiting for the client, but it gives the largest window we can easilyprovide. Noted while experimenting with new control-C code for psql.

1 parentaa30e0e commit067e40cCopy full SHA for 067e40c

File tree

1 file changed

-1

lines changed

src/backend/tcop
- fastpath.c

1 file changed

-1

lines changed

`‎src/backend/tcop/fastpath.c`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/tcop/fastpath.c,v 1.87 2006/06/11 15:49:28 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/tcop/fastpath.c,v 1.88 2006/06/14 01:24:14 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`* NOTES`
`14`	`14`	`* This cruft is the server side of PQfn.`
`@@ -382,6 +382,9 @@ HandleFunctionRequest(StringInfo msgBuf)`
`382`	`382`	`retval= (Datum)0;`
`383`	`383`	`}`
`384`	`384`
	`385`	`+/* ensure we do at least one CHECK_FOR_INTERRUPTS per function call */`
	`386`	`+CHECK_FOR_INTERRUPTS();`
	`387`	`+`
`385`	`388`	`SendFunctionResult(retval,fcinfo.isnull,fip->rettype,rformat);`
`386`	`389`
`387`	`390`	`return0;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit067e40c

File tree

1 file changed

1 file changed

`‎src/backend/tcop/fastpath.c`

0 commit comments