Commit055c352

committed

After any checkpoint, close all smgr files handles in bgwriter

1 parenta297d64 commit055c352Copy full SHA for 055c352

File tree

+36

-0

lines changed

+36

-0

lines changed

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -276,6 +276,15 @@ BackgroundWriterMain(void)`
`276`	`276`	`*/`
`277`	`277`	`pgstat_send_bgwriter();`
`278`	`278`
	`279`	`+if (FirstCallSinceLastCheckpoint())`
	`280`	`+{`
	`281`	`+/*`
	`282`	`+ * After any checkpoint, close all smgr files.This is so we`
	`283`	`+ * won't hang onto smgr references to deleted files indefinitely.`
	`284`	`+ */`
	`285`	`+smgrcloseall();`
	`286`	`+}`
	`287`	`+`
`279`	`288`	`/*`
`280`	`289`	`* Sleep until we are signaled or BgWriterDelay has elapsed.`
`281`	`290`	`*`

Lines changed: 25 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1346,3 +1346,28 @@ UpdateSharedMemoryConfig(void)`
`1346`	`1346`
`1347`	`1347`	`elog(DEBUG2,"checkpointer updated shared memory configuration values");`
`1348`	`1348`	`}`
	`1349`	`+`
	`1350`	`+/*`
	`1351`	`+ * FirstCallSinceLastCheckpoint allows a process to take an action once`
	`1352`	`+ * per checkpoint cycle by asynchronously checking for checkpoint completion.`
	`1353`	`+ */`
	`1354`	`+bool`
	`1355`	`+FirstCallSinceLastCheckpoint(void)`
	`1356`	`+{`
	`1357`	`+/* use volatile pointer to prevent code rearrangement */`
	`1358`	`+volatileCheckpointerShmemStruct*cps=CheckpointerShmem;`
	`1359`	`+staticintckpt_done=0;`
	`1360`	`+intnew_done;`
	`1361`	`+boolFirstCall= false;`
	`1362`	`+`
	`1363`	`+SpinLockAcquire(&cps->ckpt_lck);`
	`1364`	`+new_done=cps->ckpt_done;`
	`1365`	`+SpinLockRelease(&cps->ckpt_lck);`
	`1366`	`+`
	`1367`	`+if (new_done!=ckpt_done)`
	`1368`	`+FirstCall= true;`
	`1369`	`+`
	`1370`	`+ckpt_done=new_done;`
	`1371`	`+`
	`1372`	`+returnFirstCall;`
	`1373`	`+}`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,4 +38,6 @@ extern void AbsorbFsyncRequests(void);`
`38`	`38`	`externSizeCheckpointerShmemSize(void);`
`39`	`39`	`externvoidCheckpointerShmemInit(void);`
`40`	`40`
	`41`	`+externboolFirstCallSinceLastCheckpoint(void);`
	`42`	`+`
`41`	`43`	`#endif/* _BGWRITER_H */`

Comments

(0)