NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit0398ece

committed

Fix inconsequential fd leak in the new mark_file_as_archived() function.

As every error in mark_file_as_archived() will lead to a failure ofpg_basebackup the FD leak couldn't ever lead to a real problem. Itseems better to fix the leak anyway though, rather than silenceCoverity, as the usage of the function might get extended or copied atsome point in the future.Pointed out by Coverity.Backpatch to 9.2, like the relevant part of the previous patch.

1 parent2c0a485 commit0398eceCopy full SHA for 0398ece

File tree

1 file changed

-0

lines changed

src/bin/pg_basebackup
- receivelog.c

1 file changed

-0

lines changed

`‎src/bin/pg_basebackup/receivelog.c`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,9 @@ mark_file_as_archived(const char basedir, const char fname)`
`81`	`81`	`{`
`82`	`82`	`fprintf(stderr,_("%s: could not fsync file \"%s\": %s\n"),`
`83`	`83`	`progname,tmppath,strerror(errno));`
	`84`	`+`
	`85`	`+close(fd);`
	`86`	`+`
`84`	`87`	`return false;`
`85`	`88`	`}`
`86`	`89`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0398ece

File tree

1 file changed

1 file changed

`‎src/bin/pg_basebackup/receivelog.c`

0 commit comments