NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit0319da6

committed

Reset per-tuple memory context between every row in a scan node, even when

there's no quals or projections. Currently this only matters for foreignscans, as none of the other scan nodes litter the per-tuple memory contextwhen there's no quals or projections.

1 parent27c7875 commit0319da6Copy full SHA for 0319da6

File tree

1 file changed

-1

lines changed

src/backend/executor
- execScan.c

1 file changed

-1

lines changed

`‎src/backend/executor/execScan.c`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -120,13 +120,17 @@ ExecScan(ScanState *node,`
`120`	`120`	`*/`
`121`	`121`	`qual=node->ps.qual;`
`122`	`122`	`projInfo=node->ps.ps_ProjInfo;`
	`123`	`+econtext=node->ps.ps_ExprContext;`
`123`	`124`
`124`	`125`	`/*`
`125`	`126`	`* If we have neither a qual to check nor a projection to do, just skip`
`126`	`127`	`* all the overhead and return the raw scan tuple.`
`127`	`128`	`*/`
`128`	`129`	`if (!qual&& !projInfo)`
	`130`	`+{`
	`131`	`+ResetExprContext(econtext);`
`129`	`132`	`returnExecScanFetch(node,accessMtd,recheckMtd);`
	`133`	`+}`
`130`	`134`
`131`	`135`	`/*`
`132`	`136`	`* Check to see if we're still projecting out tuples from a previous scan`
`@@ -148,7 +152,6 @@ ExecScan(ScanState *node,`
`148`	`152`	`* storage allocated in the previous tuple cycle. Note this can't happen`
`149`	`153`	`* until we're done projecting out tuples from a scan tuple.`
`150`	`154`	`*/`
`151`		`-econtext=node->ps.ps_ExprContext;`
`152`	`155`	`ResetExprContext(econtext);`
`153`	`156`
`154`	`157`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0319da6

File tree

1 file changed

1 file changed

`‎src/backend/executor/execScan.c`

0 commit comments