NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit0268d21

committed

Fix unportable shell-script syntax in pg_upgrade's test.sh.

I discovered the hard way that on some old shells, the locution FOO="" unset FOOdoes not behave the same as FOO=""; unset FOOand in fact leaves FOO set to an empty string. test.sh was inconsistentlyspelling it different ways on adjacent lines.This got broken relatively recently, in commitc737a2e, so the lack offield reports to date doesn't represent a lot of evidence that the problemis rare.

1 parent2861e8e commit0268d21Copy full SHA for 0268d21

File tree

1 file changed

-2

lines changed

contrib/pg_upgrade
- test.sh

1 file changed

-2

lines changed

`‎contrib/pg_upgrade/test.sh`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -83,10 +83,10 @@ mkdir "$logdir"`
`83`	`83`	`PGDATABASE="";unset PGDATABASE`
`84`	`84`	`PGUSER="";unset PGUSER`
`85`	`85`	`PGSERVICE="";unset PGSERVICE`
`86`		`-PGSSLMODE=""unset PGSSLMODE`
	`86`	`+PGSSLMODE="";unset PGSSLMODE`
`87`	`87`	`PGREQUIRESSL="";unset PGREQUIRESSL`
`88`	`88`	`PGCONNECT_TIMEOUT="";unset PGCONNECT_TIMEOUT`
`89`		`-PGHOST=""unset PGHOST`
	`89`	`+PGHOST="";unset PGHOST`
`90`	`90`	`PGHOSTADDR="";unset PGHOSTADDR`
`91`	`91`
`92`	`92`	`# Select a non-conflicting port number, similarly to pg_regress.c`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0268d21

File tree

1 file changed

1 file changed

`‎contrib/pg_upgrade/test.sh`

0 commit comments