- Notifications
You must be signed in to change notification settings - Fork5
Commit02566f1
committed
On Sat, Aug 25, 2001 at 08:15:45PM -0400, Bruce Momjian wrote:
> Can someone research this and figure out what the proper solution for> this is? Seems we are going around in circles if we keep> adding/removing DLLIMPORT.I believe that the attached patch is the correct solution -- I apologizefor the gyrations. With the attached patch, Cygwin libpq++ buildscleanly again. The root cause was that DLLIMPORT was defaulting to__declspec(dllimport) since BUILDING_DLL was *not* defined when buildingthe libpq++ DLL.Unfortunately, to test my patch requires changing the following makefile: src/interfaces/libpq++/examples/Makefileand the #includes in all of the *.cc to build against the source treeinstead of the following hardcoded installation directory structure: /usr/local/pgsqlI was able to manually build src/interfaces/libpq++/examples/testlibpq0.exeagainst my Cygwin libpq++ without errors. However, I have not tried toactually test testlibpq0.exe.Is this sufficient? Or, do you want me to clean up libpq++/examples too?(Or, is it silly to even ask? :,)) Let me know how you want to proceed andI will submit a patch to pgsql-patches.Jason Tishler1 parent16910e4 commit02566f1
1 file changed
+5
-1
lines changedLines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
31 | 35 | | |
32 | 36 | | |
33 | 37 | | |
| |||
0 commit comments
Comments
(0)