NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit018eb02

committed

Do not DROP default roles in pg_dumpall -c

When pulling the list of roles to drop, exclude roles whose namesbegin with "pg_" (as we do when we are dumping the roles out torecreate them).Also add regression tests to cover pg_dumpall -c and this specificissue.Noticed by Rushabh Lathia. Patch by me.

1 parentf5e7b2f commit018eb02Copy full SHA for 018eb02

File tree

2 files changed

+93

-2

lines changed

src/bin/pg_dump
- pg_dumpall.c
- t
  - 002_pg_dump.pl

2 files changed

+93

-2

lines changed

`‎src/bin/pg_dump/pg_dumpall.c`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -605,7 +605,13 @@ dropRoles(PGconn *conn)`
`605`	`605`	`inti_rolname;`
`606`	`606`	`inti;`
`607`	`607`
`608`		`-if (server_version >=80100)`
	`608`	`+if (server_version >=90600)`
	`609`	`+res=executeQuery(conn,`
	`610`	`+"SELECT rolname "`
	`611`	`+"FROM pg_authid "`
	`612`	`+"WHERE rolname !~ '^pg_' "`
	`613`	`+"ORDER BY 1");`
	`614`	`+elseif (server_version >=80100)`
`609`	`615`	`res=executeQuery(conn,`
`610`	`616`	`"SELECT rolname "`
`611`	`617`	`"FROM pg_authid "`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit018eb02

File tree

2 files changed

2 files changed

`‎src/bin/pg_dump/pg_dumpall.c`

0 commit comments