- Notifications
You must be signed in to change notification settings - Fork5
Commit0059c42
committed
>Well, if it is that easy, I can do it. Patch attached and applied.
>>> On Mon, 3 Sep 2001 22:01:17 -0500, you wrote:>> public boolean isWritable(int column) throws SQLException>> {>> return !isReadOnly(column);>> }Actually, I think this change has a consequence for this methodin the same class: public boolean isDefinitelyWritable(int column) throws SQLException { return isWritable(column); }This is from the JDBC spec(http://java.sun.com/j2se/1.3/docs/api/java/sql/ResultSetMetaData.html): isReadOnly() - Indicates whether the designated column isdefinitely not writable. isWritable() - Indicates whether it is possible for a write onthe designated column to succeed. isDefinitelyWritable() - Indicates whether a write on thedesignated column will definitely succeed.At this time we don't really implement the fine semantics ofthese methods. I would suggest the following defaults: isReadOnly() false isWritable() true isDefinitelyWritable() falseAnd that would mean that your patch is correct, butisDefinitelyWritable() would need to be patched accordingly: public boolean isDefinitelyWritable(int column) throws SQLException { return false; }Again, both in jdbc1 and jdbc2.Regards,Ren? Pijlman <rene@lab.applinet.nl>1 parent1fbb2d9 commit0059c42
File tree
2 files changed
+2
-2
lines changed- src/interfaces/jdbc/org/postgresql
- jdbc1
- jdbc2
2 files changed
+2
-2
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
434 | 434 | | |
435 | 435 | | |
436 | 436 | | |
437 | | - | |
| 437 | + | |
438 | 438 | | |
439 | 439 | | |
440 | 440 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
429 | 429 | | |
430 | 430 | | |
431 | 431 | | |
432 | | - | |
| 432 | + | |
433 | 433 | | |
434 | 434 | | |
435 | 435 | | |
| |||
0 commit comments
Comments
(0)