NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit0038c1e

committed

Use ereport(ERROR) instead of Assert() to emit syncrep_parser error.

The existing code would either Assert or generate an invalidSyncRepConfig variable, neither of which is desirable. A regularerror should be thrown instead.This commit silences compiler warning in non assertion-enabled builds.Per report from Jeff Janes.Suggested fix by Tom Lane.

1 parentf73b2bb commit0038c1eCopy full SHA for 0038c1e

File tree

1 file changed

-1

lines changed

src/backend/replication
- syncrep.c

1 file changed

-1

lines changed

`‎src/backend/replication/syncrep.c`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -886,9 +886,14 @@ SyncRepUpdateConfig(void)`
`886`	`886`	`*/`
`887`	`887`	`syncrep_scanner_init(SyncRepStandbyNames);`
`888`	`888`	`parse_rc=syncrep_yyparse();`
`889`		`-Assert(parse_rc==0);`
`890`	`889`	`syncrep_scanner_finish();`
`891`	`890`
	`891`	`+if (parse_rc!=0)`
	`892`	`+ereport(ERROR,`
	`893`	`+(errcode(ERRCODE_SYNTAX_ERROR),`
	`894`	`+errmsg_internal("synchronous_standby_names parser returned %d",`
	`895`	`+parse_rc)));`
	`896`	`+`
`892`	`897`	`SyncRepConfig=syncrep_parse_result;`
`893`	`898`	`syncrep_parse_result=NULL;`
`894`	`899`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0038c1e

File tree

1 file changed

1 file changed

`‎src/backend/replication/syncrep.c`

0 commit comments