NotificationsYou must be signed in to change notification settings
Fork28
Star153

Commitff87fab

committed

Remove duplicated comment block in event_trigger.c

The reasons why event triggers are disabled in standalone mode aredocumented in the code path of ddl_command_start, and other placeschecking if standalone mode is enabled or not mention to refer to thecomment for ddl_command_start, except for table_rewrite that duplicatedthe same explanation.Reported-by: David G. JohnstonDiscussion:https://postgr.es/m/CAKFQuwYqHtXpvr2mBJRwH9f+Y5y1GXw3rhbaAu0Dk2MoNevsmA@mail.gmail.com

1 parent2e619f8 commitff87fabCopy full SHA for ff87fab

File tree

1 file changed

-14

lines changed

src/backend/commands
- event_trigger.c

1 file changed

-14

lines changed

`‎src/backend/commands/event_trigger.c‎`

Lines changed: 2 additions & 14 deletions

Original file line number	Diff line number	Diff line change
`@@ -833,20 +833,8 @@ EventTriggerTableRewrite(Node *parsetree, Oid tableOid, int reason)`
`833`	`833`	`EventTriggerDatatrigdata;`
`834`	`834`
`835`	`835`	`/*`
`836`		`- * Event Triggers are completely disabled in standalone mode. There are`
`837`		`- * (at least) two reasons for this:`
`838`		`- *`
`839`		`- * 1. A sufficiently broken event trigger might not only render the`
`840`		`- * database unusable, but prevent disabling itself to fix the situation.`
`841`		`- * In this scenario, restarting in standalone mode provides an escape`
`842`		`- * hatch.`
`843`		`- *`
`844`		`- * 2. BuildEventTriggerCache relies on systable_beginscan_ordered, and`
`845`		`- * therefore will malfunction if pg_event_trigger's indexes are damaged.`
`846`		`- * To allow recovery from a damaged index, we need some operating mode`
`847`		`- * wherein event triggers are disabled. (Or we could implement`
`848`		`- * heapscan-and-sort logic for that case, but having disaster recovery`
`849`		`- * scenarios depend on code that's otherwise untested isn't appetizing.)`
	`836`	`+ * See EventTriggerDDLCommandStart for a discussion about why event`
	`837`	`+ * triggers are disabled in single user mode.`
`850`	`838`	`*/`
`851`	`839`	`if (!IsUnderPostmaster)`
`852`	`840`	`return;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitff87fab

File tree

1 file changed

1 file changed

`‎src/backend/commands/event_trigger.c‎`

0 commit comments