NotificationsYou must be signed in to change notification settings
Fork28
Star153

Commitff43b3e

committed

Sync our DTrace infrastructure with c.h's definition of type bool.

Since commitd26a810, we've defined bool as being either _Bool from<stdbool.h>, or "unsigned char"; but that commit overlooked the factthat probes.d has "#define bool char". For consistency, make it say"unsigned char" instead. This should be strictly a cosmetic change,but it seems best to be in sync.Formally, in the now-normal case where we're using <stdbool.h>, it'dbe better to write "#define bool _Bool". However, then we'd needsome build infrastructure to inject that configuration choice intoprobes.d, and it doesn't seem worth the trouble. We only use<stdbool.h> if sizeof(_Bool) is 1, so having DTrace think thatbool parameters are "unsigned char" should be close enough.Back-patch to v12 whered26a810 came in.Discussion:https://postgr.es/m/CAA4eK1LmaKO7Du9M9Lo=kxGU8sB6aL8fa3sF6z6d5yYYVe3BuQ@mail.gmail.com

1 parentd40abd5 commitff43b3eCopy full SHA for ff43b3e

File tree

2 files changed

-4

lines changed

doc/src/sgml
- monitoring.sgml
src/backend/utils
- probes.d

2 files changed

-4

lines changed

`‎doc/src/sgml/monitoring.sgml‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4638,7 +4638,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,`
`4638`	`4638`	`</row>`
`4639`	`4639`	`<row>`
`4640`	`4640`	`<entry><type>bool</type></entry>`
`4641`		`- <entry><type>char</type></entry>`
	`4641`	`+ <entry><type>unsignedchar</type></entry>`
`4642`	`4642`	`</row>`
`4643`	`4643`
`4644`	`4644`	`</tbody>`

`‎src/backend/utils/probes.d‎`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,18 +9,18 @@`
`9`	`9`
`10`	`10`
`11`	`11`	`/*`
`12`		`- * Typedefs used in PostgreSQL.`
	`12`	`+ * Typedefs used in PostgreSQL probes.`
`13`	`13`	`*`
`14`	`14`	`* NOTE: Do not use system-provided typedefs (e.g. uintptr_t, uint32_t, etc)`
`15`		`- * in probe definitions, as they cause compilation errors on macOS 10.5.`
	`15`	`+ * in probe definitions, as they cause compilation errors on macOS.`
`16`	`16`	`*/`
`17`	`17`	`#defineLocalTransactionId unsigned int`
`18`	`18`	`#defineLWLockMode int`
`19`	`19`	`#defineLOCKMODE int`
`20`	`20`	`#defineBlockNumber unsigned int`
`21`	`21`	`#defineOid unsigned int`
`22`	`22`	`#defineForkNumber int`
`23`		`-#definebool char`
	`23`	`+#defineboolunsignedchar`
`24`	`24`
`25`	`25`	`providerpostgresql {`
`26`	`26`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitff43b3e

File tree

2 files changed

2 files changed

`‎doc/src/sgml/monitoring.sgml‎`

`‎src/backend/utils/probes.d‎`

0 commit comments