NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commitfe7bbc4

committed

Fix remote position tracking in logical replication

We need to set the origin remote position to end_lsn, not commit_lsn, ascommit_lsn is the start of commit record, and we use the origin remoteposition as start position when restarting replication stream. If we'duse commit_lsn, we could request data that we already received from theremote server after a crash of a downstream server.Author: Petr Jelinek <petr.jelinek@2ndquadrant.com>

1 parentb38006e commitfe7bbc4Copy full SHA for fe7bbc4

File tree

1 file changed

-6

lines changed

src/backend/replication/logical
- worker.c

1 file changed

-6

lines changed

`‎src/backend/replication/logical/worker.c`

Lines changed: 7 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -421,9 +421,6 @@ apply_handle_begin(StringInfo s)`
`421`	`421`
`422`	`422`	`logicalrep_read_begin(s,&begin_data);`
`423`	`423`
`424`		`-replorigin_session_origin_timestamp=begin_data.committime;`
`425`		`-replorigin_session_origin_lsn=begin_data.final_lsn;`
`426`		`-`
`427`	`424`	`remote_final_lsn=begin_data.final_lsn;`
`428`	`425`
`429`	`426`	`in_remote_transaction= true;`
`@@ -443,14 +440,18 @@ apply_handle_commit(StringInfo s)`
`443`	`440`
`444`	`441`	`logicalrep_read_commit(s,&commit_data);`
`445`	`442`
`446`		`-Assert(commit_data.commit_lsn==replorigin_session_origin_lsn);`
`447`		`-Assert(commit_data.committime==replorigin_session_origin_timestamp);`
`448`		`-`
`449`	`443`	`Assert(commit_data.commit_lsn==remote_final_lsn);`
`450`	`444`
`451`	`445`	`/* The synchronization worker runs in single transaction. */`
`452`	`446`	`if (IsTransactionState()&& !am_tablesync_worker())`
`453`	`447`	`{`
	`448`	`+/*`
	`449`	`+ * Update origin state so we can restart streaming from correct`
	`450`	`+ * position in case of crash.`
	`451`	`+ */`
	`452`	`+replorigin_session_origin_lsn=commit_data.end_lsn;`
	`453`	`+replorigin_session_origin_timestamp=commit_data.committime;`
	`454`	`+`
`454`	`455`	`CommitTransactionCommand();`
`455`	`456`
`456`	`457`	`store_flush_position(commit_data.end_lsn);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfe7bbc4

File tree

1 file changed

1 file changed

`‎src/backend/replication/logical/worker.c`

0 commit comments