Commitfd6b510

committed

fsync directory after rename

1 parente2b6257 commitfd6b510Copy full SHA for fd6b510

File tree

-4

lines changed

-4

lines changed

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -706,7 +706,7 @@ static bool cfs_gc_file(char* map_path, bool background)`
`706`	`706`	`cfs_state->gc_stat.scannedFiles+=1;`
`707`	`707`
`708`	`708`	`/* do we need to perform defragmentation? */`
`709`		`-if ((physSize-usedSize)100>physSizecfs_gc_threshold)`
	`709`	`+if ((uint64)(physSize-usedSize)100>(uint64)physSizecfs_gc_threshold)`
`710`	`710`	`{`
`711`	`711`	`longdelay=CFS_LOCK_MIN_TIMEOUT;`
`712`	`712`	`charfile_path= (char)palloc(suf+1);`
`@@ -950,6 +950,11 @@ static bool cfs_gc_file(char* map_path, bool background)`
`950`	`950`	`elog(WARNING,"CFS failed to rename file %s: %m",file_path);`
`951`	`951`	`gotoCleanup;`
`952`	`952`	`}`
	`953`	`+if (fsync_parent_path(file_path,LOG)!=0)`
	`954`	`+{`
	`955`	`+elog(WARNING,"CFS failed to sync directory for file %s: %m",file_path);`
	`956`	`+gotoCleanup;`
	`957`	`+}`
`953`	`958`
`954`	`959`	`ReplaceMap:`
`955`	`960`	`/*`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -330,7 +330,6 @@ static void pre_sync_fname(const char *fname, bool isdir, int elevel);`
`330`	`330`	`staticvoiddatadir_fsync_fname(constchar*fname,boolisdir,intelevel);`
`331`	`331`
`332`	`332`	`staticintfsync_fname_ext(constchar*fname,boolisdir,boolignore_perm,intelevel);`
`333`		`-staticintfsync_parent_path(constchar*fname,intelevel);`
`334`	`333`
`335`	`334`
`336`	`335`	`/*`
`@@ -3520,7 +3519,7 @@ fsync_fname_ext(const char *fname, bool isdir, bool ignore_perm, int elevel)`
`3520`	`3519`	`* This is aimed at making file operations persistent on disk in case of`
`3521`	`3520`	`* an OS crash or power failure.`
`3522`	`3521`	`*/`
`3523`		`-staticint`
	`3522`	`+int`
`3524`	`3523`	`fsync_parent_path(constchar*fname,intelevel)`
`3525`	`3524`	`{`
`3526`	`3525`	`charparentpath[MAXPGPATH];`

Lines changed: 1 addition & 1 deletion

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -120,6 +120,7 @@ extern intpg_fsync_writethrough(int fd);`
`120`	`120`	`externintpg_fdatasync(intfd);`
`121`	`121`	`externvoidpg_flush_data(intfd,off_toffset,off_tamount);`
`122`	`122`	`externvoidfsync_fname(constchar*fname,boolisdir);`
	`123`	`+externintfsync_parent_path(constchar*fname,intelevel);`
`123`	`124`	`externintdurable_rename(constcharoldfile,constcharnewfile,intloglevel);`
`124`	`125`	`externintdurable_link_or_rename(constcharoldfile,constcharnewfile,intloglevel);`
`125`	`126`	`externvoidSyncDataDirectory(void);`

Comments

(0)