NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commitfab2d0d

committed

Guard against null t->tm_zone in strftime.c.

The upstream IANA code does not guard against null TM_ZONE pointers in thisfunction, but in our code there is such a check in the other pre-existinguse of t->tm_zone. We do have some places that set pg_tm.tm_zone to NULL.I'm not entirely sure it's possible to reach strftime with such a value,but I'm not sure it isn't either, so be safe.Per Coverity complaint.

1 parentf754728 commitfab2d0dCopy full SHA for fab2d0d

File tree

1 file changed

-1

lines changed

src/timezone
- strftime.c

1 file changed

-1

lines changed

`‎src/timezone/strftime.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -459,7 +459,8 @@ _fmt(const char format, const struct pg_tm t, char pt, const char ptlim,`
`459`	`459`	`negative=diff<0;`
`460`	`460`	`if (diff==0)`
`461`	`461`	`{`
`462`		`-negative=t->tm_zone[0]=='-';`
	`462`	`+if (t->tm_zone!=NULL)`
	`463`	`+negative=t->tm_zone[0]=='-';`
`463`	`464`	`}`
`464`	`465`	`if (negative)`
`465`	`466`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfab2d0d

File tree

1 file changed

1 file changed

`‎src/timezone/strftime.c`

0 commit comments