- Notifications
You must be signed in to change notification settings - Fork28
Commitf9dfa5c
committed
Improve postmaster's logging of listen socket creation.
When one of the kernel calls in the socket()/bind()/listen() sequencefails, include the specific address we're trying to bind to in the logmessage. This greatly eases debugging of network misconfigurations.Also, after successfully setting up a listen socket, report its addressin the log, to ease verification that the expected addresses were bound.There was some debate about whether to print this message at LOG level oronly DEBUG1, but the majority of votes were for the former.Discussion:https://postgr.es/m/9564.1489091245@sss.pgh.pa.us1 parentde75281 commitf9dfa5c
2 files changed
+43
-16
lines changedLines changed: 4 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
464 | 464 |
| |
465 | 465 |
| |
466 | 466 |
| |
467 |
| - | |
| 467 | + | |
468 | 468 |
| |
469 |
| - | |
| 469 | + | |
470 | 470 |
| |
471 | 471 |
| |
472 | 472 |
| |
| |||
476 | 476 |
| |
477 | 477 |
| |
478 | 478 |
| |
479 |
| - | |
| 479 | + | |
480 | 480 |
| |
481 |
| - | |
| 481 | + | |
482 | 482 |
| |
483 | 483 |
| |
484 | 484 |
| |
|
Lines changed: 39 additions & 12 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
319 | 319 |
| |
320 | 320 |
| |
321 | 321 |
| |
| 322 | + | |
| 323 | + | |
322 | 324 |
| |
323 | 325 |
| |
324 | 326 |
| |
| |||
407 | 409 |
| |
408 | 410 |
| |
409 | 411 |
| |
410 |
| - | |
| 412 | + | |
411 | 413 |
| |
412 | 414 |
| |
413 | 415 |
| |
| |||
431 | 433 |
| |
432 | 434 |
| |
433 | 435 |
| |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
434 | 451 |
| |
435 | 452 |
| |
436 | 453 |
| |
437 | 454 |
| |
438 |
| - | |
439 |
| - | |
440 |
| - | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
441 | 458 |
| |
442 | 459 |
| |
443 | 460 |
| |
| |||
461 | 478 |
| |
462 | 479 |
| |
463 | 480 |
| |
464 |
| - | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
465 | 484 |
| |
466 | 485 |
| |
467 | 486 |
| |
| |||
476 | 495 |
| |
477 | 496 |
| |
478 | 497 |
| |
479 |
| - | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
480 | 501 |
| |
481 | 502 |
| |
482 | 503 |
| |
| |||
494 | 515 |
| |
495 | 516 |
| |
496 | 517 |
| |
497 |
| - | |
498 |
| - | |
499 |
| - | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
500 | 521 |
| |
501 | 522 |
| |
502 | 523 |
| |
| |||
533 | 554 |
| |
534 | 555 |
| |
535 | 556 |
| |
536 |
| - | |
537 |
| - | |
538 |
| - | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
539 | 560 |
| |
540 | 561 |
| |
541 | 562 |
| |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
542 | 569 |
| |
543 | 570 |
| |
544 | 571 |
| |
|
0 commit comments
Comments
(0)