NotificationsYou must be signed in to change notification settings
Fork28
Star153

Commitf81648c

committed

Fix bugs in the COPY heap-insert batching patch.

Forgot to call RestoreBkpBlocks() in the redo-function, as pointed out bySimon Riggs. In redo of a regular heap insert, it's taken care of inheap_redo(), but this new record type uses the heap2 RM, and heap2_redo()does not take care of that for you.Also, failed to reset the vmbuffer and all_visibile_cleared local variablesafter switching to a new buffer.

1 parent3ad2c8e commitf81648cCopy full SHA for f81648c

File tree

1 file changed

+10

-3

lines changed

src/backend/access/heap
- heapam.c

1 file changed

+10

-3

lines changed

`‎src/backend/access/heap/heapam.c‎`

Lines changed: 10 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -2088,9 +2088,6 @@ heap_multi_insert(Relation relation, HeapTuple *tuples, int ntuples,`
`2088`	`2088`	`{`
`2089`	`2089`	`TransactionIdxid=GetCurrentTransactionId();`
`2090`	`2090`	`HeapTuple*heaptuples;`
`2091`		`-Bufferbuffer;`
`2092`		`-Buffervmbuffer=InvalidBuffer;`
`2093`		`-boolall_visible_cleared= false;`
`2094`	`2091`	`inti;`
`2095`	`2092`	`intndone;`
`2096`	`2093`	`char*scratch=NULL;`
`@@ -2128,6 +2125,9 @@ heap_multi_insert(Relation relation, HeapTuple *tuples, int ntuples,`
`2128`	`2125`	`ndone=0;`
`2129`	`2126`	`while (ndone<ntuples)`
`2130`	`2127`	`{`
	`2128`	`+Bufferbuffer;`
	`2129`	`+Buffervmbuffer=InvalidBuffer;`
	`2130`	`+boolall_visible_cleared= false;`
`2131`	`2131`	`intnthispage;`
`2132`	`2132`
`2133`	`2133`	`/*`
`@@ -5038,6 +5038,13 @@ heap_xlog_multi_insert(XLogRecPtr lsn, XLogRecord *record)`
`5038`	`5038`	`inti;`
`5039`	`5039`	`boolisinit= (record->xl_info&XLOG_HEAP_INIT_PAGE)!=0;`
`5040`	`5040`
	`5041`	`+/*`
	`5042`	`+ * Insertion doesn't overwrite MVCC data, so no conflict processing is`
	`5043`	`+ * required.`
	`5044`	`+ */`
	`5045`	`+`
	`5046`	`+RestoreBkpBlocks(lsn,record, false);`
	`5047`	`+`
`5041`	`5048`	`xlrec= (xl_heap_multi_insert*)recdata;`
`5042`	`5049`	`recdata+=SizeOfHeapMultiInsert;`
`5043`	`5050`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf81648c

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/heapam.c‎`

0 commit comments