Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitf5a6509

Browse files
committed
PL/Python: Remove use of simple slicing API
The simple slicing API (sq_slice, sq_ass_slice) has been deprecatedsince Python 2.0 and has been removed altogether in Python 3, so removethose functions from the PLyResult class. Instead, the non-slicemapping functions mp_subscript and mp_ass_subscript can take sliceobjects as an index. Since we just pass the index through to theunderlying list object, we already support that. Test coverage wasalready in place.
1 parentdd6073f commitf5a6509

File tree

1 file changed

+2
-22
lines changed

1 file changed

+2
-22
lines changed

‎src/pl/plpython/plpy_resultobject.c

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ static PyObject *PLy_result_nrows(PyObject *self, PyObject *args);
2020
staticPyObject*PLy_result_status(PyObject*self,PyObject*args);
2121
staticPy_ssize_tPLy_result_length(PyObject*arg);
2222
staticPyObject*PLy_result_item(PyObject*arg,Py_ssize_tidx);
23-
staticPyObject*PLy_result_slice(PyObject*arg,Py_ssize_tlidx,Py_ssize_thidx);
24-
staticintPLy_result_ass_slice(PyObject*arg,Py_ssize_tlidx,Py_ssize_thidx,PyObject*slice);
2523
staticPyObject*PLy_result_str(PyObject*arg);
2624
staticPyObject*PLy_result_subscript(PyObject*arg,PyObject*item);
2725
staticintPLy_result_ass_subscript(PyObject*self,PyObject*item,PyObject*value);
@@ -35,9 +33,9 @@ static PySequenceMethods PLy_result_as_sequence = {
3533
NULL,/* sq_concat */
3634
NULL,/* sq_repeat */
3735
PLy_result_item,/* sq_item */
38-
PLy_result_slice,/* sq_slice */
36+
NULL,/* sq_slice */
3937
NULL,/* sq_ass_item */
40-
PLy_result_ass_slice,/* sq_ass_slice */
38+
NULL,/* sq_ass_slice */
4139
};
4240

4341
staticPyMappingMethodsPLy_result_as_mapping= {
@@ -254,24 +252,6 @@ PLy_result_item(PyObject *arg, Py_ssize_t idx)
254252
returnrv;
255253
}
256254

257-
staticPyObject*
258-
PLy_result_slice(PyObject*arg,Py_ssize_tlidx,Py_ssize_thidx)
259-
{
260-
PLyResultObject*ob= (PLyResultObject*)arg;
261-
262-
returnPyList_GetSlice(ob->rows,lidx,hidx);
263-
}
264-
265-
staticint
266-
PLy_result_ass_slice(PyObject*arg,Py_ssize_tlidx,Py_ssize_thidx,PyObject*slice)
267-
{
268-
intrv;
269-
PLyResultObject*ob= (PLyResultObject*)arg;
270-
271-
rv=PyList_SetSlice(ob->rows,lidx,hidx,slice);
272-
returnrv;
273-
}
274-
275255
staticPyObject*
276256
PLy_result_str(PyObject*arg)
277257
{

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp