NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commitf2c5870

committed

Rethink how to get float.h in old Windows API for isnan/isinf

We include <float.h> in every place that needs isnan(), because MSVCused to require it. However, since MSVC 2013 that's no longer necessary(cf. commitcec8394), so we can retire the inclusion to aversion-specific stanza in win32_port.h, where it doesn't need topollute random .c files. The header is of course still needed in a fewplaces for other reasons.I (Álvaro) removed float.h from a few more files than in Emre's originalpatch. This doesn't break the build in my system, but we'll see whatthe buildfarm has to say about it all.Author: Emre HasegeliDiscussion:https://postgr.es/m/CAE2gYzyc0+5uG+Cd9-BSL7NKC8LSHLNg1Aq2=8ubjnUwut4_iw@mail.gmail.com

1 parenta01d0fa commitf2c5870Copy full SHA for f2c5870

File tree

24 files changed

-35

lines changed

contrib
- cube
  - cube.c
- jsonb_plperl
  - jsonb_plperl.c
- tsm_system_time
  - tsm_system_time.c
src
- backend
  - access
    - gist
      - gistproc.c
      - gistutil.c
    - tablesample
      - bernoulli.c
      - system.c
  - optimizer/path
    - costsize.c
  - utils
    - adt
    - misc
      - help_config.c
- include/port
  - win32_port.h
- interfaces/ecpg
  - ecpglib
    - data.c
    - execute.c
  - pgtypeslib
    - datetime.c
    - timestamp.c
- port
  - rint.c
  - snprintf.c
- test/regress
  - regress.c

24 files changed

-35

lines changed

`‎contrib/cube/cube.c‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@`
`8`	`8`
`9`	`9`	`#include"postgres.h"`
`10`	`10`
`11`		`-#include<float.h>`
`12`	`11`	`#include<math.h>`
`13`	`12`
`14`	`13`	`#include"access/gist.h"`

`‎contrib/jsonb_plperl/jsonb_plperl.c‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`#include"postgres.h"`
`2`	`2`
`3`		`-#include<float.h>`
`4`	`3`	`#include<math.h>`
`5`	`4`
`6`	`5`	`/* Defined by Perl */`

`‎contrib/tsm_system_time/tsm_system_time.c‎`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -24,9 +24,6 @@`
`24`	`24`
`25`	`25`	`#include"postgres.h"`
`26`	`26`
`27`		`-#ifdef_MSC_VER`
`28`		`-#include<float.h>/* for _isnan */`
`29`		`-#endif`
`30`	`27`	`#include<math.h>`
`31`	`28`
`32`	`29`	`#include"access/relscan.h"`

`‎src/backend/access/gist/gistproc.c‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@`
`17`	`17`	`*/`
`18`	`18`	`#include"postgres.h"`
`19`	`19`
`20`		`-#include<float.h>`
`21`	`20`	`#include<math.h>`
`22`	`21`
`23`	`22`	`#include"access/gist.h"`

`‎src/backend/access/gist/gistutil.c‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,6 @@`
`13`	`13`	`*/`
`14`	`14`	`#include"postgres.h"`
`15`	`15`
`16`		`-#include<float.h>`
`17`	`16`	`#include<math.h>`
`18`	`17`
`19`	`18`	`#include"access/gist_private.h"`

`‎src/backend/access/tablesample/bernoulli.c‎`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -24,9 +24,6 @@`
`24`	`24`
`25`	`25`	`#include"postgres.h"`
`26`	`26`
`27`		`-#ifdef_MSC_VER`
`28`		`-#include<float.h>/* for _isnan */`
`29`		`-#endif`
`30`	`27`	`#include<math.h>`
`31`	`28`
`32`	`29`	`#include"access/hash.h"`

`‎src/backend/access/tablesample/system.c‎`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -24,9 +24,6 @@`
`24`	`24`
`25`	`25`	`#include"postgres.h"`
`26`	`26`
`27`		`-#ifdef_MSC_VER`
`28`		`-#include<float.h>/* for _isnan */`
`29`		`-#endif`
`30`	`27`	`#include<math.h>`
`31`	`28`
`32`	`29`	`#include"access/hash.h"`

`‎src/backend/optimizer/path/costsize.c‎`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -71,9 +71,6 @@`
`71`	`71`
`72`	`72`	`#include"postgres.h"`
`73`	`73`
`74`		`-#ifdef_MSC_VER`
`75`		`-#include<float.h>/* for _isnan */`
`76`		`-#endif`
`77`	`74`	`#include<math.h>`
`78`	`75`
`79`	`76`	`#include"access/amapi.h"`

`‎src/backend/utils/adt/arrayfuncs.c‎`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -15,9 +15,6 @@`
`15`	`15`	`#include"postgres.h"`
`16`	`16`
`17`	`17`	`#include<ctype.h>`
`18`		`-#ifdef_MSC_VER`
`19`		`-#include<float.h>/* for _isnan */`
`20`		`-#endif`
`21`	`18`	`#include<math.h>`
`22`	`19`
`23`	`20`	`#include"access/hash.h"`

`‎src/backend/utils/adt/datetime.c‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@`
`15`	`15`	`#include"postgres.h"`
`16`	`16`
`17`	`17`	`#include<ctype.h>`
`18`		`-#include<float.h>`
`19`	`18`	`#include<limits.h>`
`20`	`19`	`#include<math.h>`
`21`	`20`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf2c5870

File tree

24 files changed

24 files changed

`‎contrib/cube/cube.c‎`

`‎contrib/jsonb_plperl/jsonb_plperl.c‎`

`‎contrib/tsm_system_time/tsm_system_time.c‎`

`‎src/backend/access/gist/gistproc.c‎`

`‎src/backend/access/gist/gistutil.c‎`

`‎src/backend/access/tablesample/bernoulli.c‎`

`‎src/backend/access/tablesample/system.c‎`

`‎src/backend/optimizer/path/costsize.c‎`

`‎src/backend/utils/adt/arrayfuncs.c‎`

`‎src/backend/utils/adt/datetime.c‎`

0 commit comments