Commitf1e237b

committed

Unconditionally write the statsfile when SIGHUP is received, to minimize

the window during which backends have no statistics file to read.

1 parentd96d7be commitf1e237bCopy full SHA for f1e237b

File tree

-4

lines changed

-4

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<!-- $PostgreSQL: pgsql/doc/src/sgml/config.sgml,v 1.188 2008/08/2515:11:00 mha Exp $ -->`
	`1`	`+<!-- $PostgreSQL: pgsql/doc/src/sgml/config.sgml,v 1.189 2008/08/2518:55:43 mha Exp $ -->`
`2`	`2`
`3`	`3`	`<chapter Id="runtime-config">`
`4`	`4`	`<title>Server Configuration</title>`
`@@ -3419,8 +3419,8 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;`
`3419`	`3419`	`<filename>pg_stat_tmp</filename>. Pointing this at a RAM based filesystem`
`3420`	`3420`	`will decrease physical I/O requirements and can lead to increased`
`3421`	`3421`	`performance. If this parameter is changed when the system is running,`
`3422`		`- thestatistics functions might return no information until a new`
`3423`		`- file has been written, which typically happens twice per second.`
	`3422`	`+there is a small window of time until thenew file has been written`
	`3423`	`+during which the statistics functions might return no information.`
`3424`	`3424`	`</para>`
`3425`	`3425`	`</listitem>`
`3426`	`3426`	`</varlistentry>`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`*`
`14`	`14`	`*Copyright (c) 2001-2008, PostgreSQL Global Development Group`
`15`	`15`	`*`
`16`		`- *$PostgreSQL: pgsql/src/backend/postmaster/pgstat.c,v 1.180 2008/08/2515:11:00 mha Exp $`
	`16`	`+ *$PostgreSQL: pgsql/src/backend/postmaster/pgstat.c,v 1.181 2008/08/2518:55:43 mha Exp $`
`17`	`17`	`* ----------`
`18`	`18`	`*/`
`19`	`19`	`#include"postgres.h"`
`@@ -2638,11 +2638,14 @@ PgstatCollectorMain(int argc, char *argv[])`
`2638`	`2638`
`2639`	`2639`	`/*`
`2640`	`2640`	`* Reload configuration if we got SIGHUP from the postmaster.`
	`2641`	`+ * Also, signal a new write of the file, so we drop a new file as`
	`2642`	`+ * soon as possible of the directory for it changes.`
`2641`	`2643`	`*/`
`2642`	`2644`	`if (got_SIGHUP)`
`2643`	`2645`	`{`
`2644`	`2646`	`ProcessConfigFile(PGC_SIGHUP);`
`2645`	`2647`	`got_SIGHUP= false;`
	`2648`	`+need_statwrite= true;`
`2646`	`2649`	`}`
`2647`	`2650`
`2648`	`2651`	`/*`

Comments

(0)