NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commitf19a764

committed

remove useless and obsolete functions, fix format string in pathman_workers.c

1 parent1d8c48b commitf19a764Copy full SHA for f19a764

File tree

3 files changed

-90

lines changed

3 files changed

-90

lines changed

`‎src/pathman_workers.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -540,7 +540,7 @@ bgw_main_concurrent_part(Datum main_arg)`
`540`	`540`	`part_slot->total_rows+=rows;`
`541`	`541`	`/* Report debug message */`
`542`	`542`	`#ifdefUSE_ASSERT_CHECKING`
`543`		`-elog(DEBUG1,"%s: relocated %d rows, total:%lu [%u]",`
	`543`	`+elog(DEBUG1,"%s: relocated %d rows, total:"UINT64_FORMAT" [%u]",`
`544`	`544`	`concurrent_part_bgw,rows,part_slot->total_rows,MyProcPid);`
`545`	`545`	`#endif`
`546`	`546`	`SpinLockRelease(&part_slot->mutex);`

`‎src/utils.c`

Lines changed: 0 additions & 83 deletions

Original file line number	Diff line number	Diff line change
`@@ -176,65 +176,6 @@ bms_print(Bitmapset *bms)`
`176`	`176`	`returnstr.data;`
`177`	`177`	`}`
`178`	`178`
`179`		`-/*`
`180`		`- * Copied from util/plancat.c`
`181`		`- *`
`182`		`- * Build a targetlist representing the columns of the specified index.`
`183`		`- */`
`184`		`-List*`
`185`		`-build_index_tlist(PlannerInforoot,IndexOptInfoindex,`
`186`		`-RelationheapRelation)`
`187`		`-{`
`188`		`-List*tlist=NIL;`
`189`		`-Indexvarno=index->rel->relid;`
`190`		`-ListCell*indexpr_item;`
`191`		`-inti;`
`192`		`-`
`193`		`-indexpr_item=list_head(index->indexprs);`
`194`		`-for (i=0;i<index->ncolumns;i++)`
`195`		`-{`
`196`		`-intindexkey=index->indexkeys[i];`
`197`		`-Expr*indexvar;`
`198`		`-`
`199`		`-if (indexkey!=0)`
`200`		`-{`
`201`		`-/* simple column */`
`202`		`-Form_pg_attributeatt_tup;`
`203`		`-`
`204`		`-if (indexkey<0)`
`205`		`-att_tup=SystemAttributeDefinition(indexkey,`
`206`		`-heapRelation->rd_rel->relhasoids);`
`207`		`-else`
`208`		`-att_tup=heapRelation->rd_att->attrs[indexkey-1];`
`209`		`-`
`210`		`-indexvar= (Expr*)makeVar(varno,`
`211`		`-indexkey,`
`212`		`-att_tup->atttypid,`
`213`		`-att_tup->atttypmod,`
`214`		`-att_tup->attcollation,`
`215`		`-0);`
`216`		`-}`
`217`		`-else`
`218`		`-{`
`219`		`-/* expression column */`
`220`		`-if (indexpr_item==NULL)`
`221`		`-elog(ERROR,"wrong number of index expressions");`
`222`		`-indexvar= (Expr*)lfirst(indexpr_item);`
`223`		`-indexpr_item=lnext(indexpr_item);`
`224`		`-}`
`225`		`-`
`226`		`-tlist=lappend(tlist,`
`227`		`-makeTargetEntry(indexvar,`
`228`		`-i+1,`
`229`		`-NULL,`
`230`		`-false));`
`231`		`-}`
`232`		`-if (indexpr_item!=NULL)`
`233`		`-elog(ERROR,"wrong number of index expressions");`
`234`		`-`
`235`		`-returntlist;`
`236`		`-}`
`237`		`-`
`238`	`179`	`/*`
`239`	`180`	`* Get BTORDER_PROC for two types described by Oids`
`240`	`181`	`*/`
`@@ -583,16 +524,6 @@ is_date_type_internal(Oid typid)`
`583`	`524`	`typid==DATEOID;`
`584`	`525`	`}`
`585`	`526`
`586`		`-/*`
`587`		`- * Check if this is a string type.`
`588`		`- */`
`589`		`-bool`
`590`		`-is_string_type_internal(Oidtypid)`
`591`		`-{`
`592`		`-returntypid==TEXTOID\|\|`
`593`		`-typid==CSTRINGOID;`
`594`		`-}`
`595`		`-`
`596`	`527`
`597`	`528`	`/*`
`598`	`529`	`* Try to find binary operator.`
`@@ -652,20 +583,6 @@ get_rel_name_or_relid(Oid relid)`
`652`	`583`	`returnrelname;`
`653`	`584`	`}`
`654`	`585`
`655`		`-/*`
`656`		`- * Try to get opname or at least opid as cstring.`
`657`		`- */`
`658`		`-char*`
`659`		`-get_op_name_or_opid(Oidopid)`
`660`		`-{`
`661`		`-char*opname=get_opname(opid);`
`662`		`-`
`663`		`-if (!opname)`
`664`		`-returnDatumGetCString(DirectFunctionCall1(oidout,`
`665`		`-ObjectIdGetDatum(opid)));`
`666`		`-returnopname;`
`667`		`-}`
`668`		`-`
`669`	`586`
`670`	`587`	`#ifPG_VERSION_NUM<90600`
`671`	`588`	`/*`

`‎src/utils.h`

Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -32,9 +32,6 @@ typedef struct`
`32`	`32`	`voidplan_tree_walker(Plan*plan,`
`33`	`33`	`void (visitor) (Planplan,void*context),`
`34`	`34`	`void*context);`
`35`		`-Listbuild_index_tlist(PlannerInforoot,`
`36`		`-IndexOptInfo*index,`
`37`		`-RelationheapRelation);`
`38`	`35`	`voidchange_varnos(Node*node,Oidold_varno,Oidnew_varno);`
`39`	`36`
`40`	`37`	`/*`
`@@ -48,7 +45,6 @@ void postprocess_lock_rows(List rtable, Plan plan);`
`48`	`45`	`*/`
`49`	`46`	`boolclause_contains_params(Node*clause);`
`50`	`47`	`boolis_date_type_internal(Oidtypid);`
`51`		`-boolis_string_type_internal(Oidtypid);`
`52`	`48`	`boolvalidate_on_part_init_cb(Oidprocid,boolemit_error);`
`53`	`49`	`boolcheck_security_policy_internal(Oidrelid,Oidrole);`
`54`	`50`
`@@ -67,8 +63,6 @@ Oid get_rel_owner(Oid relid);`
`67`	`63`	`* Handy execution-stage functions.`
`68`	`64`	`*/`
`69`	`65`	`char*get_rel_name_or_relid(Oidrelid);`
`70`		`-char*get_op_name_or_opid(Oidopid);`
`71`		`-`
`72`	`66`	`Oidget_binary_operator_oid(char*opname,Oidarg1,Oidarg2);`
`73`	`67`	`voidfill_type_cmp_fmgr_info(FmgrInfo*finfo,`
`74`	`68`	`Oidtype1,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf19a764

File tree

3 files changed

3 files changed

`‎src/pathman_workers.c`

`‎src/utils.c`

`‎src/utils.h`

0 commit comments