Commitf184de3

committed

Give a more specific error message if you try to COMMIT, ROLLBACK or COPY

FROM STDIN in PL/pgSQL. We alread did this for dynamic EXECUTE statements,ie. "EXECUTE 'COMMIT'", but not otherwise.

1 parent6c3c7b5 commitf184de3Copy full SHA for f184de3

File tree

+11

-0

lines changed

+11

-0

lines changed

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2889,6 +2889,17 @@ exec_stmt_execsql(PLpgSQL_execstate *estate,`
`2889`	`2889`	`exec_set_found(estate, false);`
`2890`	`2890`	`break;`
`2891`	`2891`
	`2892`	`+/* Some SPI errors deserve specific error messages */`
	`2893`	`+caseSPI_ERROR_COPY:`
	`2894`	`+ereport(ERROR,`
	`2895`	`+(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
	`2896`	`+errmsg("cannot COPY to/from client in PL/pgSQL")));`
	`2897`	`+caseSPI_ERROR_TRANSACTION:`
	`2898`	`+ereport(ERROR,`
	`2899`	`+(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
	`2900`	`+errmsg("cannot begin/end transactions in PL/pgSQL"),`
	`2901`	`+errhint("Use a BEGIN block with an EXCEPTION clause instead.")));`
	`2902`	`+`
`2892`	`2903`	`default:`
`2893`	`2904`	`elog(ERROR,"SPI_execute_plan_with_paramlist failed executing query \"%s\": %s",`
`2894`	`2905`	`expr->query,SPI_result_code_string(rc));`

Comments

(0)