NotificationsYou must be signed in to change notification settings
Fork28
Star153

Commitec99dd5

committed

Remove incorrect assertion in clog.c

We must advance the oldest XID that can be safely looked up in clog*before* truncating CLOG, and the oldest XID that can't be reused*after* truncating CLOG. This assertion, and the accompanyingcomment, are confused; remove them.Reported by Neha Sharma.Discussion:http://postgr.es/m/CANiYTQumC3T=UMBMd1Hor=5XWZYuCEQBioL3ug0YtNQCMMT5wQ@mail.gmail.com

1 parent749c7c4 commitec99dd5Copy full SHA for ec99dd5

File tree

1 file changed

-4

lines changed

src/backend/access/transam
- clog.c

1 file changed

-4

lines changed

`‎src/backend/access/transam/clog.c‎`

Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -678,10 +678,6 @@ TruncateCLOG(TransactionId oldestXact, Oid oldestxid_datoid)`
`678`	`678`	`*/`
`679`	`679`	`AdvanceOldestClogXid(oldestXact);`
`680`	`680`
`681`		`-/* vac_truncate_clog already advanced oldestXid */`
`682`		`-Assert(TransactionIdPrecedesOrEquals(oldestXact,`
`683`		`-ShmemVariableCache->oldestXid));`
`684`		`-`
`685`	`681`	`/*`
`686`	`682`	`* Write XLOG record and flush XLOG to disk. We record the oldest xid`
`687`	`683`	`* we're keeping information about here so we can ensure that it's always`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitec99dd5

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/clog.c‎`

0 commit comments