NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commitec7629d

committed

Teach bitmap heap scan to cope with absence of a DSA.

If we have a plan that uses parallelism but are unable to execute itusing parallelism, for example due to a lack of available DSMsegments, then the EState's es_query_dsa will be NULL. Parallelbitmap heap scan needs to fall back to a non-parallel scan in suchcases.Patch by me, reviewed by Dilip KumarDiscussion:http://postgr.es/m/CAEepm=0kADK5inNf_KuemjX=HQ=PuTP0DykM--fO5jS5ePVFEA@mail.gmail.com

1 parent7015bb3 commitec7629dCopy full SHA for ec7629d

File tree

1 file changed

+11

-0

lines changed

src/backend/executor
- nodeBitmapHeapscan.c

1 file changed

+11

-0

lines changed

`‎src/backend/executor/nodeBitmapHeapscan.c`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -963,6 +963,11 @@ ExecBitmapHeapInitializeDSM(BitmapHeapScanState *node,`
`963`	`963`	`{`
`964`	`964`	`ParallelBitmapHeapState*pstate;`
`965`	`965`	`EState*estate=node->ss.ps.state;`
	`966`	`+dsa_area*dsa=node->ss.ps.state->es_query_dsa;`
	`967`	`+`
	`968`	`+/* If there's no DSA, there are no workers; initialize nothing. */`
	`969`	`+if (dsa==NULL)`
	`970`	`+return;`
`966`	`971`
`967`	`972`	`pstate=shm_toc_allocate(pcxt->toc,node->pscan_len);`
`968`	`973`
`@@ -995,6 +1000,10 @@ ExecBitmapHeapReInitializeDSM(BitmapHeapScanState *node,`
`995`	`1000`	`ParallelBitmapHeapState*pstate=node->pstate;`
`996`	`1001`	`dsa_area*dsa=node->ss.ps.state->es_query_dsa;`
`997`	`1002`
	`1003`	`+/* If there's no DSA, there are no workers; do nothing. */`
	`1004`	`+if (dsa==NULL)`
	`1005`	`+return;`
	`1006`	`+`
`998`	`1007`	`pstate->state=BM_INITIAL;`
`999`	`1008`
`1000`	`1009`	`if (DsaPointerIsValid(pstate->tbmiterator))`
`@@ -1019,6 +1028,8 @@ ExecBitmapHeapInitializeWorker(BitmapHeapScanState node, shm_toc toc)`
`1019`	`1028`	`ParallelBitmapHeapState*pstate;`
`1020`	`1029`	`Snapshotsnapshot;`
`1021`	`1030`
	`1031`	`+Assert(node->ss.ps.state->es_query_dsa!=NULL);`
	`1032`	`+`
`1022`	`1033`	`pstate=shm_toc_lookup(toc,node->ss.ps.plan->plan_node_id, false);`
`1023`	`1034`	`node->pstate=pstate;`
`1024`	`1035`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitec7629d

File tree

1 file changed

1 file changed

`‎src/backend/executor/nodeBitmapHeapscan.c`

0 commit comments