NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commite69b8d4

committed

Fix memory leak in relcache handling of rules: allocate rule parsetrees

in per-entry sub-memory-context, where they were supposed to go, ratherthan in CacheMemoryContext where the code was putting them. Must'vesuffered a severe brain fade when I wrote this :-(

1 parentca88243 commite69b8d4Copy full SHA for e69b8d4

File tree

1 file changed

-3

lines changed

src/backend/utils/cache
- relcache.c

1 file changed

-3

lines changed

`‎src/backend/utils/cache/relcache.c`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/utils/cache/relcache.c,v 1.124 2001/01/0601:48:59 inoue Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/cache/relcache.c,v 1.125 2001/01/0621:53:18 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -881,7 +881,7 @@ RelationBuildRuleLock(Relation relation)`
`881`	`881`	`Assert(!isnull);`
`882`	`882`	`ruleaction_str=DatumGetCString(DirectFunctionCall1(textout,`
`883`	`883`	`ruleaction));`
`884`		`-oldcxt=MemoryContextSwitchTo(CacheMemoryContext);`
	`884`	`+oldcxt=MemoryContextSwitchTo(rulescxt);`
`885`	`885`	`rule->actions= (List*)stringToNode(ruleaction_str);`
`886`	`886`	`MemoryContextSwitchTo(oldcxt);`
`887`	`887`	`pfree(ruleaction_str);`
`@@ -893,7 +893,7 @@ RelationBuildRuleLock(Relation relation)`
`893`	`893`	`Assert(!isnull);`
`894`	`894`	`rule_evqual_str=DatumGetCString(DirectFunctionCall1(textout,`
`895`	`895`	`rule_evqual));`
`896`		`-oldcxt=MemoryContextSwitchTo(CacheMemoryContext);`
	`896`	`+oldcxt=MemoryContextSwitchTo(rulescxt);`
`897`	`897`	`rule->qual= (Node*)stringToNode(rule_evqual_str);`
`898`	`898`	`MemoryContextSwitchTo(oldcxt);`
`899`	`899`	`pfree(rule_evqual_str);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite69b8d4

File tree

1 file changed

1 file changed

`‎src/backend/utils/cache/relcache.c`

0 commit comments