- Notifications
You must be signed in to change notification settings - Fork28
Commite343eaa
committed
Mark internal_in as not strict, so that the construct "null::internal"
will throw an error, rather than possibly allowing someone to synthesizea manual call to an internal-accepting function. As of CVS HEAD and existingreleases, all such functions are either STRICT or careful about null inputs,so there is no current security issue here. But it seems like a good ideato lock this down to protect against future mistakes.In passing, similarly lock down trigger_in, language_handler_in, opaque_in,and shell_in. These are not believed to present any security risk, butthere's still no good reason to allow nulls of these types to be created.I left the polymorphic pseudotypes (anyelement etc) alone, since a nullof one of those types doesn't seem to be a problem --- the worst you cansay about it is that it doesn't have an underlying non-polymorphic type.If we were to make this change during normal development, we'd justautomatically bump catversion for a pg_proc.h change. But since this doesn'tcreate a compatibility risk and isn't believed to be fixing a live bug, itseems better not to force a catversion bump in late beta.1 parente66576e commite343eaa
1 file changed
+6
-6
lines changedLines changed: 6 additions & 6 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
7 | 7 |
| |
8 | 8 |
| |
9 | 9 |
| |
10 |
| - | |
| 10 | + | |
11 | 11 |
| |
12 | 12 |
| |
13 | 13 |
| |
| |||
3702 | 3702 |
| |
3703 | 3703 |
| |
3704 | 3704 |
| |
3705 |
| - | |
| 3705 | + | |
3706 | 3706 |
| |
3707 | 3707 |
| |
3708 | 3708 |
| |
3709 |
| - | |
| 3709 | + | |
3710 | 3710 |
| |
3711 | 3711 |
| |
3712 | 3712 |
| |
3713 |
| - | |
| 3713 | + | |
3714 | 3714 |
| |
3715 | 3715 |
| |
3716 | 3716 |
| |
3717 |
| - | |
| 3717 | + | |
3718 | 3718 |
| |
3719 | 3719 |
| |
3720 | 3720 |
| |
3721 | 3721 |
| |
3722 | 3722 |
| |
3723 | 3723 |
| |
3724 | 3724 |
| |
3725 |
| - | |
| 3725 | + | |
3726 | 3726 |
| |
3727 | 3727 |
| |
3728 | 3728 |
| |
|
0 commit comments
Comments
(0)