Commite1bacb7

committed

Enforce REPEATABLE READ since currently we export snap only once in xact

There is also no distribute predicate locking support, so SERIALIZABLE is notthe way to go too.

1 parent221220a commite1bacb7Copy full SHA for e1bacb7

File tree

-0

lines changed

-0

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -501,10 +501,15 @@ begin_remote_xact(ConnCacheEntry *entry)`
`501`	`501`	`elog(DEBUG3,"starting remote transaction on connection %p",`
`502`	`502`	`entry->conn);`
`503`	`503`
	`504`	`+if (UseGlobalSnapshots&& (!IsolationUsesXactSnapshot()\|\|`
	`505`	`+IsolationIsSerializable()))`
	`506`	`+elog(ERROR,"Global snapshots support only REPEATABLE READ");`
	`507`	`+`
`504`	`508`	`sprintf(sql,"START TRANSACTION %s; set application_name='pgfdw:%lld:%d';",`
`505`	`509`	`IsolationIsSerializable() ?"ISOLATION LEVEL SERIALIZABLE" :`
`506`	`510`	`UseRepeatableRead ?"ISOLATION LEVEL REPEATABLE READ" :"",`
`507`	`511`	`(long long)GetSystemIdentifier(),MyProcPid);`
	`512`	`+`
`508`	`513`	`entry->changing_xact_state= true;`
`509`	`514`	`do_sql_command(entry,sql);`
`510`	`515`	`entry->xact_depth=1;`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`	`log_checkpoints = true`
`13`	`13`	`postgres_fdw.use_global_snapshots = on`
`14`	`14`	`track_global_snapshots = on`
	`15`	`+default_transaction_isolation = 'REPEATABLE READ'`
`15`	`16`	`));`
`16`	`17`	`$master->start;`
`17`	`18`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`	`postgres_fdw.use_global_snapshots = on`
`13`	`13`	`global_snapshot_defer_time = 15`
`14`	`14`	`track_global_snapshots = on`
	`15`	`+ default_transaction_isolation = 'REPEATABLE READ'`
`15`	`16`	`));`
`16`	`17`	`$shard1->start;`
`17`	`18`
`@@ -22,6 +23,7 @@`
`22`	`23`	`postgres_fdw.use_global_snapshots = on`
`23`	`24`	`global_snapshot_defer_time = 15`
`24`	`25`	`track_global_snapshots = on`
	`26`	`+default_transaction_isolation = 'REPEATABLE READ'`
`25`	`27`	`));`
`26`	`28`	`$shard2->start;`
`27`	`29`

Comments

(0)