Commite0f76f2

committed

pg_waldump: Fix small memory leak when rmgr->rm_identify returns NULL.

This got broken in604f795, shortly after rm_identify'sintroduction.Author: Andres FreundDiscussion:https://postgr.es/m/20191029233341.4gnyau7e5v2lh5sc@alap3.anarazel.deBackpatch: 9.5, where rm_identify was introduced

1 parent6ca86bb commite0f76f2Copy full SHA for e0f76f2

File tree

-5

lines changed

-5

lines changed

Lines changed: 6 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -517,17 +517,18 @@ XLogDumpDisplayRecord(XLogDumpConfig config, XLogReaderState record)`
`517`	`517`
`518`	`518`	`XLogDumpRecordLen(record,&rec_len,&fpi_len);`
`519`	`519`
`520`		`-id=desc->rm_identify(info);`
`521`		`-if (id==NULL)`
`522`		`-id=psprintf("UNKNOWN (%x)",info& ~XLR_INFO_MASK);`
`523`		`-`
`524`	`520`	`printf("rmgr: %-11s len (rec/tot): %6u/%6u, tx: %10u, lsn: %X/%08X, prev %X/%08X, ",`
`525`	`521`	`desc->rm_name,`
`526`	`522`	`rec_len,XLogRecGetTotalLen(record),`
`527`	`523`	`XLogRecGetXid(record),`
`528`	`524`	`(uint32) (record->ReadRecPtr >>32), (uint32)record->ReadRecPtr,`
`529`	`525`	`(uint32) (xl_prev >>32), (uint32)xl_prev);`
`530`		`-printf("desc: %s ",id);`
	`526`	`+`
	`527`	`+id=desc->rm_identify(info);`
	`528`	`+if (id==NULL)`
	`529`	`+printf("desc: UNKNOWN (%x) ",info& ~XLR_INFO_MASK);`
	`530`	`+else`
	`531`	`+printf("desc: %s ",id);`
`531`	`532`
`532`	`533`	`/* the desc routine will printf the description directly to stdout */`
`533`	`534`	`desc->rm_desc(NULL,record);`

Comments

(0)