@@ -3290,28 +3290,28 @@ execute_dml_stmt(ForeignScanState *node)
32903290 * Construct array of query parameter values in text format.
32913291 */
32923292if (numParams > 0 )
3293- {
3293+ // {
32943294process_query_params (econtext ,
32953295dmstate -> param_flinfo ,
32963296dmstate -> param_exprs ,
32973297values );
32983298
3299- /*
3300-
3301-
3302-
3303-
3304-
3305-
3306- if (!PQsendQueryParams (dmstate -> conn ,dmstate -> query ,numParams ,
3307- NULL ,values ,NULL ,NULL ,0 ))
3308- pgfdw_report_error (ERROR ,NULL ,dmstate -> conn , false,dmstate -> query );
3309- }
3310- else
3311- {
3312- if (!PQsendQuery (dmstate -> conn ,dmstate -> query ))
3313- pgfdw_report_error (ERROR ,NULL ,dmstate -> conn , false,dmstate -> query );
3314- }
3299+ /*
3300+ * Notice that we pass NULL for paramTypes, thus forcing the remote server
3301+ * to infer types for all parameters. Since we explicitly cast every
3302+ * parameter (see deparse.c), the "inference" is trivial and will produce
3303+ * the desired result. This allows us to avoid assuming that the remote
3304+ * server has the same OIDs we do for the parameters' types.
3305+ */
3306+ if (!PQsendQueryParams (dmstate -> conn ,dmstate -> query ,numParams ,
3307+ NULL ,values ,NULL ,NULL ,0 ))
3308+ pgfdw_report_error (ERROR ,NULL ,dmstate -> conn , false,dmstate -> query );
3309+ // }
3310+ // else
3311+ // {
3312+ // if (!PQsendQuery(dmstate->conn, dmstate->query))
3313+ // pgfdw_report_error(ERROR, NULL, dmstate->conn, false, dmstate->query);
3314+ // }
33153315
33163316/*
33173317 * Get the result, and check for success.