NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commitded87de

committed

rewrited drop_triggers() func and tests are fixed

1 parentdd01513 commitded87deCopy full SHA for ded87de

File tree

9 files changed

+68

-84

lines changed

9 files changed

+68

-84

lines changed

`‎expected/pathman_basic.out`

Lines changed: 13 additions & 22 deletions

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,6 @@ SELECT * FROM test.hash_rel;`
`81`	`81`	`(3 rows)`
`82`	`82`
`83`	`83`	`SELECT pathman.drop_partitions('test.hash_rel');`
`84`		`-NOTICE: function test.hash_rel_upd_trig_func() does not exist, skipping`
`85`	`84`	`NOTICE: 0 rows copied from test.hash_rel_0`
`86`	`85`	`NOTICE: 0 rows copied from test.hash_rel_1`
`87`	`86`	`NOTICE: 0 rows copied from test.hash_rel_2`
`@@ -570,10 +569,10 @@ SET pg_pathman.enable_runtimeappend = OFF;`
`570`	`569`	`SET pg_pathman.enable_runtimemergeappend = OFF;`
`571`	`570`	`VACUUM;`
`572`	`571`	`/* update triggers test */`
`573`		`-SELECT pathman.create_hash_update_trigger('test.hash_rel');`
`574`		`-create_hash_update_trigger`
`575`		`------------------------------`
`576`		`-test.hash_rel_upd_trig_func`
	`572`	`+SELECT pathman.create_update_triggers('test.hash_rel');`
	`573`	`+create_update_triggers`
	`574`	`+------------------------`
	`575`	`+`
`577`	`576`	`(1 row)`
`578`	`577`
`579`	`578`	`UPDATE test.hash_rel SET value = 7 WHERE value = 6;`
`@@ -591,10 +590,10 @@ SELECT * FROM test.hash_rel WHERE value = 7;`
`591`	`590`	`6 \| 7`
`592`	`591`	`(1 row)`
`593`	`592`
`594`		`-SELECT pathman.create_range_update_trigger('test.num_range_rel');`
`595`		`- create_range_update_trigger`
`596`		`-----------------------------------`
`597`		`-test.num_range_rel_upd_trig_func`
	`593`	`+SELECT pathman.create_update_triggers('test.num_range_rel');`
	`594`	`+create_update_triggers`
	`595`	`+------------------------`
	`596`	`+`
`598`	`597`	`(1 row)`
`599`	`598`
`600`	`599`	`UPDATE test.num_range_rel SET id = 3001 WHERE id = 1;`
`@@ -1477,7 +1476,7 @@ SELECT pathman.replace_hash_partition('test.hash_rel_0', 'test.hash_rel_extern')`
`1477`	`1476`	`Indexes:`
`1478`	`1477`	`"hash_rel_0_pkey" PRIMARY KEY, btree (id)`
`1479`	`1478`	`Triggers:`
`1480`		`- hash_rel_upd_trig BEFORE UPDATE ON test.hash_rel_0 FOR EACH ROW EXECUTE PROCEDUREtest.hash_rel_upd_trig_func()`
	`1479`	`+ hash_rel_upd_trig BEFORE UPDATE ON test.hash_rel_0 FOR EACH ROW EXECUTE PROCEDUREpathman.update_trigger_func()`
`1481`	`1480`
`1482`	`1481`	`\d+ test.hash_rel_extern`
`1483`	`1482`	`Table "test.hash_rel_extern"`
`@@ -1513,7 +1512,6 @@ EXPLAIN (COSTS OFF) SELECT * FROM test.hash_rel;`
`1513`	`1512`	`* Clean up`
`1514`	`1513`	`*/`
`1515`	`1514`	`SELECT pathman.drop_partitions('test.hash_rel');`
`1516`		`-NOTICE: drop cascades to 2 other objects`
`1517`	`1515`	`NOTICE: 3 rows copied from test.hash_rel_1`
`1518`	`1516`	`NOTICE: 2 rows copied from test.hash_rel_2`
`1519`	`1517`	`NOTICE: 2 rows copied from test.hash_rel_extern`
`@@ -1535,7 +1533,6 @@ SELECT pathman.create_hash_partitions('test.hash_rel', 'value', 3);`
`1535`	`1533`	`(1 row)`
`1536`	`1534`
`1537`	`1535`	`SELECT pathman.drop_partitions('test.hash_rel', TRUE);`
`1538`		`-NOTICE: function test.hash_rel_upd_trig_func() does not exist, skipping`
`1539`	`1536`	`drop_partitions`
`1540`	`1537`	`-----------------`
`1541`	`1538`	`3`
`@@ -1549,7 +1546,6 @@ SELECT COUNT(*) FROM ONLY test.hash_rel;`
`1549`	`1546`
`1550`	`1547`	`DROP TABLE test.hash_rel CASCADE;`
`1551`	`1548`	`SELECT pathman.drop_partitions('test.num_range_rel');`
`1552`		`-NOTICE: drop cascades to 3 other objects`
`1553`	`1549`	`NOTICE: 998 rows copied from test.num_range_rel_1`
`1554`	`1550`	`NOTICE: 1000 rows copied from test.num_range_rel_2`
`1555`	`1551`	`NOTICE: 1000 rows copied from test.num_range_rel_3`
`@@ -1690,10 +1686,10 @@ SELECT * FROM test."TeSt";`
`1690`	`1686`	`1 \| 1`
`1691`	`1687`	`(3 rows)`
`1692`	`1688`
`1693`		`-SELECT pathman.create_hash_update_trigger('test."TeSt"');`
`1694`		`-create_hash_update_trigger`
`1695`		`-----------------------------`
`1696`		`-test."TeSt_upd_trig_func"`
	`1689`	`+SELECT pathman.create_update_triggers('test."TeSt"');`
	`1690`	`+create_update_triggers`
	`1691`	`+------------------------`
	`1692`	`+`
`1697`	`1693`	`(1 row)`
`1698`	`1694`
`1699`	`1695`	`UPDATE test."TeSt" SET a = 1;`
`@@ -1722,7 +1718,6 @@ EXPLAIN (COSTS OFF) SELECT * FROM test."TeSt" WHERE a = 1;`
`1722`	`1718`	`(3 rows)`
`1723`	`1719`
`1724`	`1720`	`SELECT pathman.drop_partitions('test."TeSt"');`
`1725`		`-NOTICE: drop cascades to 3 other objects`
`1726`	`1721`	`NOTICE: 0 rows copied from test."TeSt_0"`
`1727`	`1722`	`NOTICE: 0 rows copied from test."TeSt_1"`
`1728`	`1723`	`NOTICE: 3 rows copied from test."TeSt_2"`
`@@ -1777,7 +1772,6 @@ SELECT pathman.split_range_partition('test."RangeRel_1"', '2015-01-01'::DATE);`
`1777`	`1772`	`(1 row)`
`1778`	`1773`
`1779`	`1774`	`SELECT pathman.drop_partitions('test."RangeRel"');`
`1780`		`-NOTICE: function test.RangeRel_upd_trig_func() does not exist, skipping`
`1781`	`1775`	`NOTICE: 0 rows copied from test."RangeRel_1"`
`1782`	`1776`	`NOTICE: 1 rows copied from test."RangeRel_2"`
`1783`	`1777`	`NOTICE: 1 rows copied from test."RangeRel_3"`
`@@ -1813,7 +1807,6 @@ SELECT pathman.create_range_partitions('test."RangeRel"', 'id', 1, 100, 3);`
`1813`	`1807`	`(1 row)`
`1814`	`1808`
`1815`	`1809`	`SELECT pathman.drop_partitions('test."RangeRel"');`
`1816`		`-NOTICE: function test.RangeRel_upd_trig_func() does not exist, skipping`
`1817`	`1810`	`NOTICE: 0 rows copied from test."RangeRel_1"`
`1818`	`1811`	`NOTICE: 0 rows copied from test."RangeRel_2"`
`1819`	`1812`	`NOTICE: 0 rows copied from test."RangeRel_3"`
`@@ -1971,7 +1964,6 @@ EXPLAIN (COSTS OFF) DELETE FROM test.range_rel r USING test.tmp t WHERE r.dt = '`
`1971`	`1964`	`DELETE FROM test.range_rel r USING test.tmp t WHERE r.dt = '2010-01-02' AND r.id = t.id;`
`1972`	`1965`	`/* Create range partitions from whole range */`
`1973`	`1966`	`SELECT drop_partitions('test.range_rel');`
`1974`		`-NOTICE: function test.range_rel_upd_trig_func() does not exist, skipping`
`1975`	`1967`	`NOTICE: 44 rows copied from test.range_rel_1`
`1976`	`1968`	`NOTICE: 31 rows copied from test.range_rel_3`
`1977`	`1969`	`NOTICE: 30 rows copied from test.range_rel_4`
`@@ -1998,7 +1990,6 @@ SELECT create_partitions_from_range('test.range_rel', 'id', 1, 1000, 100);`
`1998`	`1990`	`(1 row)`
`1999`	`1991`
`2000`	`1992`	`SELECT drop_partitions('test.range_rel', TRUE);`
`2001`		`-NOTICE: function test.range_rel_upd_trig_func() does not exist, skipping`
`2002`	`1993`	`drop_partitions`
`2003`	`1994`	`-----------------`
`2004`	`1995`	`10`

`‎expected/pathman_calamity.out`

Lines changed: 0 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,6 @@ NOTICE: sequence "part_test_seq" does not exist, skipping`
`28`	`28`	`(1 row)`
`29`	`29`
`30`	`30`	`SELECT drop_partitions('calamity.part_test');`
`31`		`-NOTICE: function calamity.part_test_upd_trig_func() does not exist, skipping`
`32`	`31`	`NOTICE: 10 rows copied from calamity.part_test_1`
`33`	`32`	`NOTICE: 10 rows copied from calamity.part_test_2`
`34`	`33`	`NOTICE: 10 rows copied from calamity.part_test_3`
`@@ -44,7 +43,6 @@ SELECT create_range_partitions('calamity.part_test', 'val', 1, 10);`
`44`	`43`	`(1 row)`
`45`	`44`
`46`	`45`	`SELECT drop_partitions('calamity.part_test');`
`47`		`-NOTICE: function calamity.part_test_upd_trig_func() does not exist, skipping`
`48`	`46`	`NOTICE: 10 rows copied from calamity.part_test_1`
`49`	`47`	`NOTICE: 10 rows copied from calamity.part_test_2`
`50`	`48`	`NOTICE: 10 rows copied from calamity.part_test_3`
`@@ -66,7 +64,6 @@ SELECT append_range_partition('calamity.part_test');`
`66`	`64`	`(1 row)`
`67`	`65`
`68`	`66`	`SELECT drop_partitions('calamity.part_test');`
`69`		`-NOTICE: function calamity.part_test_upd_trig_func() does not exist, skipping`
`70`	`67`	`NOTICE: 10 rows copied from calamity.part_test_1`
`71`	`68`	`NOTICE: 10 rows copied from calamity.part_test_2`
`72`	`69`	`NOTICE: 10 rows copied from calamity.part_test_3`
`@@ -89,7 +86,6 @@ SELECT append_range_partition('calamity.part_test');`
`89`	`86`	`(1 row)`
`90`	`87`
`91`	`88`	`SELECT drop_partitions('calamity.part_test');`
`92`		`-NOTICE: function calamity.part_test_upd_trig_func() does not exist, skipping`
`93`	`89`	`NOTICE: 10 rows copied from calamity.part_test_1`
`94`	`90`	`NOTICE: 10 rows copied from calamity.part_test_2`
`95`	`91`	`NOTICE: 10 rows copied from calamity.part_test_3`
`@@ -171,7 +167,6 @@ EXPLAIN (COSTS OFF) SELECT * FROM calamity.part_test;`
`171`	`167`	`(5 rows)`
`172`	`168`
`173`	`169`	`SELECT drop_partitions('calamity.part_test', true);`
`174`		`-NOTICE: function calamity.part_test_upd_trig_func() does not exist, skipping`
`175`	`170`	`drop_partitions`
`176`	`171`	`-----------------`
`177`	`172`	`4`
`@@ -199,7 +194,6 @@ ERROR: invalid input syntax for integer: "15.6"`
`199`	`194`	`SELECT set_interval('calamity.part_test', 'abc'::text);/* not ok */`
`200`	`195`	`ERROR: invalid input syntax for integer: "abc"`
`201`	`196`	`SELECT drop_partitions('calamity.part_test', true);`
`202`		`-NOTICE: function calamity.part_test_upd_trig_func() does not exist, skipping`
`203`	`197`	`drop_partitions`
`204`	`198`	`-----------------`
`205`	`199`	`3`
`@@ -479,7 +473,6 @@ SELECT add_to_pathman_config('calamity.part_test', 'val');/* OK */`
`479`	`473`	`(1 row)`
`480`	`474`
`481`	`475`	`SELECT disable_pathman_for('calamity.part_test');`
`482`		`-NOTICE: function calamity.part_test_upd_trig_func() does not exist, skipping`
`483`	`476`	`disable_pathman_for`
`484`	`477`	`---------------------`
`485`	`478`
`@@ -492,7 +485,6 @@ SELECT add_to_pathman_config('calamity.part_test', 'val', '10'); /* OK */`
`492`	`485`	`(1 row)`
`493`	`486`
`494`	`487`	`SELECT disable_pathman_for('calamity.part_test');`
`495`		`-NOTICE: function calamity.part_test_upd_trig_func() does not exist, skipping`
`496`	`488`	`disable_pathman_for`
`497`	`489`	`---------------------`
`498`	`490`
`@@ -599,7 +591,6 @@ SELECT set_enable_parent('calamity.to_be_disabled', true); /* add row to params`
`599`	`591`	`(1 row)`
`600`	`592`
`601`	`593`	`SELECT disable_pathman_for('calamity.to_be_disabled'); /* should delete both rows */`
`602`		`-NOTICE: function calamity.to_be_disabled_upd_trig_func() does not exist, skipping`
`603`	`594`	`disable_pathman_for`
`604`	`595`	`---------------------`
`605`	`596`

`‎expected/pathman_callbacks.out`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,6 @@ WARNING: callback arg: {"parent": "abc", "parttype": "2", "partition": "abc_7",`
`133`	`133`	`(1 row)`
`134`	`134`
`135`	`135`	`SELECT drop_partitions('callbacks.abc');`
`136`		`-NOTICE: function callbacks.abc_upd_trig_func() does not exist, skipping`
`137`	`136`	`NOTICE: 0 rows copied from callbacks.abc_1`
`138`	`137`	`NOTICE: 1 rows copied from callbacks.abc_2`
`139`	`138`	`NOTICE: 1 rows copied from callbacks.abc_3`

`‎expected/pathman_cte.out`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,6 @@ WHERE t.id = tmp.tid AND t.pdate = tmp.pdate AND tmp.test_mode > 0;`
`121`	`121`	`(24 rows)`
`122`	`122`
`123`	`123`	`SELECT drop_partitions('test_cte.cte_del_xacts'); /* now drop partitions */`
`124`		`-NOTICE: function test_cte.cte_del_xacts_upd_trig_func() does not exist, skipping`
`125`	`124`	`NOTICE: 50 rows copied from test_cte.cte_del_xacts_1`
`126`	`125`	`NOTICE: 50 rows copied from test_cte.cte_del_xacts_2`
`127`	`126`	`drop_partitions`

`‎expected/pathman_domains.out`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,6 @@ ORDER BY range_min::INT, range_max::INT;`
`88`	`88`	`(14 rows)`
`89`	`89`
`90`	`90`	`SELECT drop_partitions('domains.dom_table');`
`91`		`-NOTICE: function domains.dom_table_upd_trig_func() does not exist, skipping`
`92`	`91`	`NOTICE: 49 rows copied from domains.dom_table_1`
`93`	`92`	`NOTICE: 100 rows copied from domains.dom_table_3`
`94`	`93`	`NOTICE: 100 rows copied from domains.dom_table_4`

`‎expected/pathman_foreign_keys.out`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@ INSERT INTO fkeys.test_fkey VALUES(1, 'wrong');`
`20`	`20`	`ERROR: insert or update on table "test_fkey_1" violates foreign key constraint "test_fkey_1_comment_fkey"`
`21`	`21`	`INSERT INTO fkeys.test_fkey VALUES(1, 'test');`
`22`	`22`	`SELECT drop_partitions('fkeys.test_fkey');`
`23`		`-NOTICE: function fkeys.test_fkey_upd_trig_func() does not exist, skipping`
`24`	`23`	`NOTICE: 101 rows copied from fkeys.test_fkey_1`
`25`	`24`	`NOTICE: 100 rows copied from fkeys.test_fkey_2`
`26`	`25`	`NOTICE: 100 rows copied from fkeys.test_fkey_3`
`@@ -46,7 +45,6 @@ INSERT INTO fkeys.test_fkey VALUES(1, 'wrong');`
`46`	`45`	`ERROR: insert or update on table "test_fkey_0" violates foreign key constraint "test_fkey_0_comment_fkey"`
`47`	`46`	`INSERT INTO fkeys.test_fkey VALUES(1, 'test');`
`48`	`47`	`SELECT drop_partitions('fkeys.test_fkey');`
`49`		`-NOTICE: function fkeys.test_fkey_upd_trig_func() does not exist, skipping`
`50`	`48`	`NOTICE: 100 rows copied from fkeys.test_fkey_0`
`51`	`49`	`NOTICE: 90 rows copied from fkeys.test_fkey_1`
`52`	`50`	`NOTICE: 90 rows copied from fkeys.test_fkey_2`

`‎expected/pathman_permissions.out`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,6 @@ ERROR: no suitable partition for key '55'`
`134`	`134`	`/* Finally drop partitions */`
`135`	`135`	`SET ROLE user1;`
`136`	`136`	`SELECT drop_partitions('permissions.user1_table');`
`137`		`-NOTICE: function permissions.user1_table_upd_trig_func() does not exist, skipping`
`138`	`137`	`NOTICE: 10 rows copied from permissions.user1_table_1`
`139`	`138`	`NOTICE: 10 rows copied from permissions.user1_table_2`
`140`	`139`	`NOTICE: 0 rows copied from permissions.user1_table_4`
`@@ -157,7 +156,6 @@ SELECT create_hash_partitions('permissions.user2_table', 'id', 3);`
`157`	`156`
`158`	`157`	`INSERT INTO permissions.user2_table SELECT generate_series(1, 30);`
`159`	`158`	`SELECT drop_partitions('permissions.user2_table');`
`160`		`-NOTICE: function permissions.user2_table_upd_trig_func() does not exist, skipping`
`161`	`159`	`NOTICE: 9 rows copied from permissions.user2_table_0`
`162`	`160`	`NOTICE: 11 rows copied from permissions.user2_table_1`
`163`	`161`	`NOTICE: 10 rows copied from permissions.user2_table_2`

`‎init.sql`

Lines changed: 52 additions & 43 deletions

Original file line number	Diff line number	Diff line change
`@@ -551,15 +551,64 @@ $$`
`551`	`551`	`LANGUAGE plpgsql;`
`552`	`552`
`553`	`553`	`/*`
`554`		`- * Drop triggers.`
	`554`	`+ * Function for update triggers`
	`555`	`+*/`
	`556`	`+CREATEOR REPLACE FUNCTION @extschema@.update_trigger_func()`
	`557`	`+RETURNS TRIGGERAS'pg_pathman','update_trigger_func'`
	`558`	`+LANGUAGE C;`
	`559`	`+`
	`560`	`+/*`
	`561`	`+ * Creates an update trigger`
	`562`	`+*/`
	`563`	`+CREATEOR REPLACE FUNCTION @extschema@.create_update_triggers(`
	`564`	`+IN parent_relidREGCLASS)`
	`565`	`+RETURNS VOIDAS`
	`566`	`+$$`
	`567`	`+DECLARE`
	`568`	`+triggerTEXT :='CREATE TRIGGER %s`
	`569`	`+ BEFORE UPDATE ON %s`
	`570`	`+ FOR EACH ROW EXECUTE PROCEDURE`
	`571`	`+ @extschema@.update_trigger_func()';`
	`572`	`+triggernameTEXT;`
	`573`	`+recRECORD;`
	`574`	`+`
	`575`	`+BEGIN`
	`576`	`+triggername := @extschema@.build_update_trigger_name(parent_relid);`
	`577`	`+`
	`578`	`+/* Create trigger on every partition*/`
	`579`	`+FOR recin (SELECT*FROMpg_catalog.pg_inherits`
	`580`	`+WHERE inhparent= parent_relid)`
	`581`	`+LOOP`
	`582`	`+EXECUTE format(trigger,`
	`583`	`+ triggername,`
	`584`	`+rec.inhrelid::REGCLASS::TEXT);`
	`585`	`+END LOOP;`
	`586`	`+END`
	`587`	`+$$ LANGUAGE plpgsql;`
	`588`	`+`
	`589`	`+/*`
	`590`	`+ * Drop triggers`
`555`	`591`	`*/`
`556`	`592`	`CREATEOR REPLACE FUNCTION @extschema@.drop_triggers(`
`557`	`593`	`parent_relidREGCLASS)`
`558`	`594`	`RETURNS VOIDAS`
`559`	`595`	`$$`
	`596`	`+DECLARE`
	`597`	`+triggernameTEXT;`
	`598`	`+recRECORD;`
	`599`	`+`
`560`	`600`	`BEGIN`
`561`		`-EXECUTE format('DROP FUNCTION IF EXISTS %s() CASCADE',`
`562`		`- @extschema@.build_update_trigger_func_name(parent_relid));`
	`601`	`+triggername := @extschema@.build_update_trigger_name(parent_relid);`
	`602`	`+`
	`603`	`+/* Drop trigger for each partition if exists*/`
	`604`	`+FOR recIN (SELECTpg_catalog.pg_inherits.*FROMpg_catalog.pg_inherits`
	`605`	`+JOINpg_catalog.pg_triggeron inhrelid= tgrelid`
	`606`	`+WHERE inhparent= parent_relidAND tgname= triggername)`
	`607`	`+LOOP`
	`608`	`+EXECUTE format('DROP TRIGGER IF EXISTS %s ON %s',`
	`609`	`+ triggername,`
	`610`	`+rec.inhrelid::REGCLASS::TEXT);`
	`611`	`+END LOOP;`
`563`	`612`	`END`
`564`	`613`	`$$ LANGUAGE plpgsql STRICT;`
`565`	`614`
`@@ -896,43 +945,3 @@ CREATE OR REPLACE FUNCTION @extschema@.invoke_on_partition_created_callback(`
`896`	`945`	`init_callbackREGPROCEDURE)`
`897`	`946`	`RETURNS VOIDAS'pg_pathman','invoke_on_partition_created_callback'`
`898`	`947`	`LANGUAGE C;`
`899`		`-`
`900`		`-`
`901`		`-/*`
`902`		`- * Function for update triggers`
`903`		`-*/`
`904`		`-CREATEOR REPLACE FUNCTION @extschema@.update_trigger_func()`
`905`		`-RETURNS TRIGGERAS'pg_pathman','update_trigger_func'`
`906`		`-LANGUAGE C;`
`907`		`-`
`908`		`-`
`909`		`-/*`
`910`		`- * Creates an update trigger`
`911`		`-*/`
`912`		`-CREATEOR REPLACE FUNCTION @extschema@.create_update_trigger(`
`913`		`-IN parent_relidREGCLASS)`
`914`		`-RETURNSTEXTAS`
`915`		`-$$`
`916`		`-DECLARE`
`917`		`-triggerTEXT :='CREATE TRIGGER %s`
`918`		`- BEFORE UPDATE ON %s`
`919`		`- FOR EACH ROW EXECUTE PROCEDURE`
`920`		`- @extschema@.update_trigger_func()';`
`921`		`-triggernameTEXT;`
`922`		`-recRECORD;`
`923`		`-`
`924`		`-BEGIN`
`925`		`-triggername := @extschema@.build_update_trigger_name(parent_relid);`
`926`		`-`
`927`		`-/* Create trigger on every partition*/`
`928`		`-FOR recin (SELECT*FROMpg_catalog.pg_inherits`
`929`		`-WHERE inhparent= parent_relid)`
`930`		`-LOOP`
`931`		`-EXECUTE format(trigger,`
`932`		`- triggername,`
`933`		`-rec.inhrelid::REGCLASS::TEXT);`
`934`		`-END LOOP;`
`935`		`-`
`936`		`-RETURN'update_trigger_func()';`
`937`		`-END`
`938`		`-$$ LANGUAGE plpgsql;`

`‎sql/pathman_basic.sql`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -173,12 +173,12 @@ SET pg_pathman.enable_runtimemergeappend = OFF;`
`173`	`173`	`VACUUM;`
`174`	`174`
`175`	`175`	`/* update triggers test*/`
`176`		`-SELECTpathman.create_hash_update_trigger('test.hash_rel');`
	`176`	`+SELECTpathman.create_update_triggers('test.hash_rel');`
`177`	`177`	`UPDATEtest.hash_relSET value=7WHERE value=6;`
`178`	`178`	`EXPLAIN (COSTS OFF)SELECT*FROMtest.hash_relWHERE value=7;`
`179`	`179`	`SELECT*FROMtest.hash_relWHERE value=7;`
`180`	`180`
`181`		`-SELECTpathman.create_range_update_trigger('test.num_range_rel');`
	`181`	`+SELECTpathman.create_update_triggers('test.num_range_rel');`
`182`	`182`	`UPDATEtest.num_range_relSET id=3001WHERE id=1;`
`183`	`183`	`EXPLAIN (COSTS OFF)SELECT*FROMtest.num_range_relWHERE id=3001;`
`184`	`184`	`SELECT*FROMtest.num_range_relWHERE id=3001;`
`@@ -464,7 +464,7 @@ INSERT INTO test."TeSt" VALUES (1, 1);`
`464`	`464`	`INSERT INTO test."TeSt"VALUES (2,2);`
`465`	`465`	`INSERT INTO test."TeSt"VALUES (3,3);`
`466`	`466`	`SELECT*FROM test."TeSt";`
`467`		`-SELECTpathman.create_hash_update_trigger('test."TeSt"');`
	`467`	`+SELECTpathman.create_update_triggers('test."TeSt"');`
`468`	`468`	`UPDATE test."TeSt"SET a=1;`
`469`	`469`	`SELECT*FROM test."TeSt";`
`470`	`470`	`SELECT*FROM test."TeSt"WHERE a=1;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitded87de

File tree

9 files changed

9 files changed

`‎expected/pathman_basic.out`

`‎expected/pathman_calamity.out`

`‎expected/pathman_callbacks.out`

`‎expected/pathman_cte.out`

`‎expected/pathman_domains.out`

`‎expected/pathman_foreign_keys.out`

`‎expected/pathman_permissions.out`

`‎init.sql`

`‎sql/pathman_basic.sql`

0 commit comments