Commitde75281

committed

pg_dump: Fix dumping of publications

Dumping a publication with more than one table crashed pg_dump.patch by Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, test by me

1 parent6ec4c85 commitde75281Copy full SHA for de75281

File tree

+29

-0

lines changed

+29

-0

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3557,6 +3557,7 @@ getPublicationTables(Archive *fout, TableInfo tblinfo[], int numTables)`
`3557`	`3557`	`pubrinfo[j].dobj.catId.oid = atooid(PQgetvalue(res, j, i_oid));`
`3558`	`3558`	`AssignDumpId(&pubrinfo[j].dobj);`
`3559`	`3559`	`pubrinfo[j].dobj.namespace = tbinfo->dobj.namespace;`
	`3560`	`+pubrinfo[j].dobj.name = tbinfo->dobj.name;`
`3560`	`3561`	`pubrinfo[j].pubname = pg_strdup(PQgetvalue(res, j, i_pubname));`
`3561`	`3562`	`pubrinfo[j].pubtable = tbinfo;`
`3562`	`3563`	`}`

Lines changed: 28 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2286,6 +2286,34 @@`
`2286`	`2286`	`exclude_test_table => 1,`
`2287`	`2287`	`pg_dumpall_globals => 1,`
`2288`	`2288`	`pg_dumpall_globals_clean => 1, }, },`
	`2289`	`+'ALTER PUBLICATION pub1 ADD TABLE test_second_table' => {`
	`2290`	`+create_order => 52,`
	`2291`	`+create_sql =>`
	`2292`	`+ 'ALTER PUBLICATION pub1 ADD TABLE dump_test.test_second_table;',`
	`2293`	`+regexp => qr/^`
	`2294`	`+\QALTER PUBLICATION pub1 ADD TABLE test_second_table;\E`
	`2295`	`+/xm,`
	`2296`	`+like => {`
	`2297`	`+binary_upgrade => 1,`
	`2298`	`+clean => 1,`
	`2299`	`+clean_if_exists => 1,`
	`2300`	`+createdb => 1,`
	`2301`	`+defaults => 1,`
	`2302`	`+exclude_test_table => 1,`
	`2303`	`+exclude_test_table_data => 1,`
	`2304`	`+no_privs => 1,`
	`2305`	`+no_owner => 1,`
	`2306`	`+only_dump_test_schema => 1,`
	`2307`	`+pg_dumpall_dbprivs => 1,`
	`2308`	`+schema_only => 1,`
	`2309`	`+section_post_data => 1,`
	`2310`	`+test_schema_plus_blobs => 1, },`
	`2311`	`+unlike => {`
	`2312`	`+section_pre_data => 1,`
	`2313`	`+exclude_dump_test_schema => 1,`
	`2314`	`+only_dump_test_table => 1,`
	`2315`	`+pg_dumpall_globals => 1,`
	`2316`	`+pg_dumpall_globals_clean => 1, }, },`
`2289`	`2317`
`2290`	`2318`	`'CREATE SCHEMA dump_test' => {`
`2291`	`2319`	`all_runs => 1,`

Comments

(0)