Commitdd1f645

committed

Fix AddressSanitizer use-after-scope complaint.

XLogRegisterBufData() does not copy data pointed to by caller's pointerargument.Oversight in commit0d861bb.Author: Peter EisentrautReported-By: Peter EisentrautDiscussion:https://postgr.es/m/21800dbe-a13e-22f7-d423-b81db9d249f5@2ndquadrant.com

1 parent30e82f1 commitdd1f645Copy full SHA for dd1f645

File tree

-1

lines changed

-1

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1289,6 +1289,7 @@ _bt_insertonpg(Relation rel,`
`1289`	`1289`	`xl_btree_metadataxlmeta;`
`1290`	`1290`	`uint8xlinfo;`
`1291`	`1291`	`XLogRecPtrrecptr;`
	`1292`	`+uint16upostingoff;`
`1292`	`1293`
`1293`	`1294`	`xlrec.offnum=newitemoff;`
`1294`	`1295`
`@@ -1354,7 +1355,7 @@ _bt_insertonpg(Relation rel,`
`1354`	`1355`	`* must reconstruct final itup (as well as nposting) using`
`1355`	`1356`	`* _bt_swap_posting().`
`1356`	`1357`	`*/`
`1357`		`-uint16upostingoff=postingoff;`
	`1358`	`+upostingoff=postingoff;`
`1358`	`1359`
`1359`	`1360`	`XLogRegisterBufData(0, (char*)&upostingoff,sizeof(uint16));`
`1360`	`1361`	`XLogRegisterBufData(0, (char*)origitup,`

Comments

(0)