NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commitdc9142f

committed

When planning a query at Bind time, be careful to pass the correct

query_list into the Portal, ie, the one seen and possibly modified bythe planner. My fault :-( Per report from Sergey Koposov.

1 parent71a6f8b commitdc9142fCopy full SHA for dc9142f

File tree

1 file changed

-5

lines changed

src/backend/tcop
- postgres.c

1 file changed

-5

lines changed

`‎src/backend/tcop/postgres.c`

Lines changed: 6 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/tcop/postgres.c,v 1.512 2006/10/0719:25:28 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/tcop/postgres.c,v 1.513 2006/10/0720:16:57 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`* NOTES`
`14`	`14`	`* this is the "main" module of the postgres backend and`
`@@ -1294,6 +1294,7 @@ exec_bind_message(StringInfo input_message)`
`1294`	`1294`	`PreparedStatement*pstmt;`
`1295`	`1295`	`Portalportal;`
`1296`	`1296`	`ParamListInfoparams;`
	`1297`	`+List*query_list;`
`1297`	`1298`	`List*plan_list;`
`1298`	`1299`	`MemoryContextqContext;`
`1299`	`1300`	`boolsave_log_statement_stats=log_statement_stats;`
`@@ -1572,13 +1573,13 @@ exec_bind_message(StringInfo input_message)`
`1572`	`1573`
`1573`	`1574`	`qContext=PortalGetHeapMemory(portal);`
`1574`	`1575`	`oldContext=MemoryContextSwitchTo(qContext);`
`1575`		`-plan_list=pg_plan_queries(copyObject(pstmt->query_list),`
`1576`		`-params,`
`1577`		`-true);`
	`1576`	`+query_list=copyObject(pstmt->query_list);`
	`1577`	`+plan_list=pg_plan_queries(query_list,params, true);`
`1578`	`1578`	`MemoryContextSwitchTo(oldContext);`
`1579`	`1579`	`}`
`1580`	`1580`	`else`
`1581`	`1581`	`{`
	`1582`	`+query_list=pstmt->query_list;`
`1582`	`1583`	`plan_list=pstmt->plan_list;`
`1583`	`1584`	`qContext=pstmt->context;`
`1584`	`1585`	`}`
`@@ -1590,7 +1591,7 @@ exec_bind_message(StringInfo input_message)`
`1590`	`1591`	`*pstmt->stmt_name ?pstmt->stmt_name :NULL,`
`1591`	`1592`	`pstmt->query_string,`
`1592`	`1593`	`pstmt->commandTag,`
`1593`		`-pstmt->query_list,`
	`1594`	`+query_list,`
`1594`	`1595`	`plan_list,`
`1595`	`1596`	`qContext);`
`1596`	`1597`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdc9142f

File tree

1 file changed

1 file changed

`‎src/backend/tcop/postgres.c`

0 commit comments