NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commitdbcd9d6

committed

Remove some of the most blatant brain-fade in the recent guc patch

(it's so nice to have a buildfarm member that actively rejects nakeduses of strcasecmp). This coding is still pretty awful, though, sinceit's going to be O(N^2) in the number of guc variables. May I directyour attention to bsearch?

1 parentafcf09d commitdbcd9d6Copy full SHA for dbcd9d6

File tree

1 file changed

-2

lines changed

src/backend/utils/misc
- guc.c

1 file changed

-2

lines changed

`‎src/backend/utils/misc/guc.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`* Written by Peter Eisentraut <peter_e@gmx.net>.`
`11`	`11`	`*`
`12`	`12`	`* IDENTIFICATION`
`13`		`- * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.387 2007/04/21 20:02:40petere Exp $`
	`13`	`+ * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.388 2007/04/22 03:52:40tgl Exp $`
`14`	`14`	`*`
`15`	`15`	`*--------------------------------------------------------------------`
`16`	`16`	`*/`
`@@ -2681,7 +2681,7 @@ guc_get_index(const char *name)`
`2681`	`2681`	`inti;`
`2682`	`2682`
`2683`	`2683`	`for (i=0;i<num_guc_variables;i++)`
`2684`		`-if (strcasecmp(name,guc_variables[i]->name)==0)`
	`2684`	`+if (guc_name_compare(name,guc_variables[i]->name)==0)`
`2685`	`2685`	`returni;`
`2686`	`2686`
`2687`	`2687`	`return-1;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdbcd9d6

File tree

1 file changed

1 file changed

`‎src/backend/utils/misc/guc.c`

0 commit comments